Dnf5/feature/config by jrohel · Pull Request #918 · rpm-software-management/libdnf

jrohel · 2020-03-20T08:56:30Z

No description provided.

Conan-Kudo

Generally looks like a good start, but there are a few things I feel should be addressed...

Conan-Kudo · 2020-03-22T20:21:32Z

+    OptionStringList & protected_packages();
+    OptionString & username();
+    OptionString & password();
+    OptionBool & gpgcheck();


Can we go ahead and lay the groundwork here for the GPG check refactor? (As noted in RhBug:1433592#c7). This is the perfect time to do so.

@Conan-Kudo Am I correct that this is a request to drop RHEL7, RHEL8 compatibility in favour of Zypper behaviour?

Somewhat. The gpgcheck_policy option would control whether we behave as YUM does or as Zypper does for gpgcheck. In general, I think the correct default is to behave like Zypper here, but I'm okay with making the default the same as YUM, as long as we can tune this.

Conan-Kudo · 2020-03-22T20:22:52Z

+    OptionPath & destdir();
+    OptionString & comment();
+    OptionBool & downloadonly();
+    OptionBool & ignorearch();


Let's go ahead and add the sticky vendor options that are part of #907.

We have to first finish review of #907.
We would like to develop dnf5 into state of libdnf master, then we will backport all additional patches from dnf-4

Conan-Kudo · 2020-03-22T20:29:15Z

+constexpr const char * PERSISTDIR = "/var/lib/dnf";
+constexpr const char * SYSTEM_CACHEDIR = "/var/cache/dnf";
+
+constexpr const char * CONF_FILENAME = "/etc/dnf/dnf.conf";


Where is the /etc/dnf/conf.d setup?

Thanks for comments. I wrote notes. The code is under development. I'm trying to reuse old code and adopt it to libdnf5.

Why '/etc/dnf/conf.d' ?

That's what's in the dnf PR: rpm-software-management/dnf#1414

j-mracek · 2020-03-24T14:13:18Z

+    virtual const char * get_domain_name() const noexcept { return "libdnf"; }
+    virtual const char * get_name() const noexcept { return "Exception"; }
+    virtual const char * get_description() const noexcept { return ""; }
+};


Shell we extend all errors by error code value?

Example:
An Exception with error code bad_value can be replaced by inherited specialized exception BadValue.

I thought about adding error code for easy transform to other languages eg C. The same approach as get_name() -> Each exception class will have unique id (error code). But how create well defined unique id? The string get_domain_name() + get_name() is unique to each exception now.

Note:
There is error_code in my SystemError exception class. Because system error codes are defined and I think that is no need to create specialized exception for each system error code.
I have some concept but it can be modified.

void swap_logger(std::unique_ptr<Logger> & logger, size_t index); Swaps the logger at the "index" position with another "logger". It is used, for example, to replace a temporary (memory buffer) logger with a final one.

Formatting library for C++. Safe printf implementation including the POSIX extension for positional arguments and implementation of C++20 std::format. Idea: If we only use C++20 style (std::format) in libdnf then the fmt library will only be needed for compilers without C++20 support.

Abstract class. Base class for all configuration options type.

Uses a new exception hierarchy, snake_case, ...

The type of option is taken from linked option during compile type. It uses topical default value and parameters from linked option during runtime.

OptionBool, OptionNumber, OptionString

OptionEnum, OptionStringList

option that represents a time duration

Support for text translation

Type safe printf() replacement

error: conversion from ‘long unsigned int’ to ‘int’ may change value [-Werror=conversion] 1017 | detail::FormatListN<sizeof...(Args)> makeFormatList(const Args&... args)

We don't want to depend on GLib, but librepo and libmodulemd use it in API.

WeakPtr is a "smart" pointer. It contains a pointer to resource and to guard of resource. WeakPtr pointer can be owner of the resource. However, the resource itself may depend on another resource. WeakPtr registers/unregisters itself at the guard of resource. And the resource guard invalidates the registered WeakPtrs when the resource is unusable (eg. its dependecny was released).

Only example will be updated.

rh-atomic-bot · 2020-04-03T01:10:54Z

☔ The latest upstream changes (presumably 188cdbc) made this pull request unmergeable. Please resolve the merge conflicts.

jrohel added the work in progress label Mar 20, 2020

jrohel force-pushed the dnf5/feature/config branch 2 times, most recently from 0c420ca to bfddb71 Compare March 22, 2020 15:29

Conan-Kudo requested changes Mar 22, 2020

View reviewed changes

jrohel force-pushed the dnf5/feature/config branch 4 times, most recently from 36efaec to deb378e Compare March 24, 2020 08:57

j-mracek reviewed Mar 24, 2020

View reviewed changes

jrohel force-pushed the dnf5/feature/config branch 7 times, most recently from 608f883 to 86e93f6 Compare March 30, 2020 08:17

jrohel added 14 commits March 31, 2020 16:48

[dnf5] Add LogRouter::swap_logger() method

12c9ad8

void swap_logger(std::unique_ptr<Logger> & logger, size_t index); Swaps the logger at the "index" position with another "logger". It is used, for example, to replace a temporary (memory buffer) logger with a final one.

[dnf5] Add LogRouter into Base class

cc1b092

[dnf5] Add base exception support

e5353d4

[dnf5] Move Option to the new location

fa8e3f4

Abstract class. Base class for all configuration options type.

[dnf5] Modify Option class for new libdnf

6fe4849

Uses a new exception hierarchy, snake_case, ...

[dnf5] Move OptionChild template class to the new location

78619f1

The type of option is taken from linked option during compile type. It uses topical default value and parameters from linked option during runtime.

[dnf5] Modify OptionChild class for new libdnf

1ceceef

[dnf5] Move basic config option types to the new location

10fb3aa

OptionBool, OptionNumber, OptionString

[dnf5] Modify implementation of basic config option types for new libdnf

23d3896

[dnf5] Move additional config option types to the new location

be5cb9b

OptionEnum, OptionStringList

[dnf5] Modify additional config option types for the new libdnf

1f58b9b

OptionEnum, OptionStringList

[dnf5] Move OptionSeconds to the new location

1de90ee

option that represents a time duration

[dnf5] Modify OptionSeconds for the new libdnf

18e7656

jrohel added 27 commits March 31, 2020 18:31

[dnf5] Modify PreserveOrderMap for new libdnf

0ddd6e2

[dnf5] Move ConfigParser from old libdnf

3277d94

[dnf5] Modify ConfigParser for new libdnf

e39b409

[dnf5] Add rpm::ConfigRepo (stores configuration of RPM repository)

6663ea8

[dnf5] Add ConfigMain into Base class

5f1ca8c

[dnf5] Base: Add methods for main configuration loading

b9daaf9

[dnf5] Load conf files from dir in alphabetical order

2b6073d

[dnf5] microdnf - load main configuration

96c6e50

[dnf5] Move bgettext to the new location

db6d591

Support for text translation

[dnf5] Move tinyformat to the new location

61b4a17

Type safe printf() replacement

[dnf5] Fix: tinyformat - FormatListN template type

9799a87

error: conversion from ‘long unsigned int’ to ‘int’ may change value [-Werror=conversion] 1017 | detail::FormatListN<sizeof...(Args)> makeFormatList(const Args&... args)

[dnf5] cmake - set gettext domain for translations

a00dd99

[dnf5] Add GLib2, GPGme, and librepo libraries

d72276e

We don't want to depend on GLib, but librepo and libmodulemd use it in API.

[dnf5] Add utils - have_files_same_content function

3ce2c31

[dnf5] Move Repo from old libdnf

0b57220

[dnf5] Modify rpm repository support (rpm::Repo) for new libdnf

81298f2

[dnf5] Add Set class

1886e21

[dnf5] Set class: Add operators | & - ^

ba6da27

[dnf5] Add Query support

682ffd8

[dnf5] Add common Sack

383768d

[dnf5] Implement rpm RepoQuery

4d5ae31

[dnf5] Implement rpm RepoSack

6171da8

[dnf5] Add rpm_repo_sack into Base

50541c4

[dnf5] Base: Add substitutions map

a0200a6

[dnf5] Support creating rpm repos from config file and directories

5bd3b40

[dnf5] microdnf: Add substitutions and repos loading, gpg import, ...

ea44f15

Only example will be updated.

jrohel force-pushed the dnf5/feature/config branch from 86e93f6 to ea44f15 Compare March 31, 2020 16:43

jrohel closed this Jul 20, 2020

Conversation

jrohel commented Mar 20, 2020

Uh oh!

Conan-Kudo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rh-atomic-bot commented Apr 3, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants