Skip to content

build: Turn compiler warnings into errors only for our code #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jrohel merged 1 commit into from
Feb 2, 2026
Merged

build: Turn compiler warnings into errors only for our code #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ find_package(PkgConfig REQUIRED)
pkg_check_modules(YAMLCPP REQUIRED IMPORTED_TARGET GLOBAL yaml-cpp)
pkg_check_modules(RPM REQUIRED IMPORTED_TARGET GLOBAL rpm)

add_compile_options(-Wall -Wextra -Werror)
add_compile_options(-Wall -Wextra)

include_directories("${PROJECT_SOURCE_DIR}/include")

Expand Down
1 change: 1 addition & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ file(GLOB_RECURSE libpkgmanifest_SOURCES *.cpp)
list(APPEND libpkgmanifest_PC_REQUIRES)
list(APPEND libpkgmanifest_PC_REQUIRES_PRIVATE)

add_compile_options(-Werror)
include_directories(.)

add_library(libpkgmanifest SHARED ${libpkgmanifest_SOURCES})
Expand Down
3 changes: 2 additions & 1 deletion test/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@ pkg_check_modules(GMOCK REQUIRED gmock)

file(GLOB_RECURSE TEST_libpkgmanifest_SOURCES *.cpp)

add_compile_options(-Werror)
include_directories(.)
include_directories(${PROJECT_SOURCE_DIR}/include)
include_directories(${PROJECT_SOURCE_DIR}/src)
Expand All @@ -22,4 +23,4 @@ set_property(TEST tests_libpkgmanifest PROPERTY ENVIRONMENT
"PROJECT_SOURCE_DIR=${PROJECT_SOURCE_DIR}"
)

add_subdirectory("python")
add_subdirectory("python")
Loading