Return UntrustedKey also for unsupported/disabled keys#109
Merged
github-actions[bot] merged 1 commit intorpm-software-management:mainfrom Apr 24, 2026
Merged
Conversation
The RPM needs to distinguish between completely broken keys and keys that are "just" untrusted by the policy. Similarly with signatures on RPMs we can return the NonTrusted return value, that can be used by RPM to differentiate these errors and allow filtering valid certificates when a file contains more of them. Signed-off-by: Jakub Jelen <jjelen@redhat.com> Co-authored-by: Neal H. Walfield <neal@sequoia-pgp.org>
nwalfield
force-pushed
the
untrusted-key
branch
from
2ecfc5b to
5a576b2
Compare
Collaborator
|
I modified the MR as discussed: if using the standard policy fails, try with the null policy. If using the null policy says |
Collaborator
|
/fast-forward |
github-actions
Bot
merged commit 5a576b2
into
rpm-software-management:main
5 of 6 checks passed
Collaborator
Author
|
Thank you! I will give it a try with the rpm tests! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up from #107, where we merged the unknown signatures, but not unknown keys during import. This was left for further discussion if this is the right thing to do.