AlternativesCheck: Fix .conf files regex#1490
Merged
danigm merged 1 commit intoopensuse-slfo-mainfrom Apr 29, 2026
Merged
Conversation
FilippoBonazziSUSE
approved these changes
Apr 7, 2026
The previous regex matches any path in /usr/share/libalternatives/ that ends with "conf" so it was crashing when trying to parse an rpm file that contains a binary "ldaptor-ldap2dhcpconf" with a libalternatives configuration. This patch fixes this issue making the regex more specific so it doesn't catch any folder, just ".conf" files.
danigm
force-pushed
the
fix-libalternatives-check-slfo-main
branch
from
c707c18 to
acca52c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous regex matches any path in /usr/share/libalternatives/ that ends with "conf" so it was crashing when trying to parse an rpm file that contains a binary "ldaptor-ldap2dhcpconf" with a libalternatives configuration.
This patch fixes this issue making the regex more specific so it doesn't catch any folder, just ".conf" files.
Cherry-pick: 27ee58a
Fix https://bugzilla.suse.com/show_bug.cgi?id=1261308