Add RPM 4.20 declarative build system preamble elements#335
Conversation
Sorted near BuildRequires.
danigm
approved these changes
Oct 29, 2025
Member
danigm
left a comment
danigm
left a comment
There was a problem hiding this comment.
LGTM. It could be nice to add also some tests for the declarative build system, but as a first look, this change looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sorted near
BuildRequires.One of the neat things about this, apart from eliminating a lot of boilerplate, is that
BuildOptionandBuildRequirescan be grouped together in conditionals.