Extend check for python_module to also support prefixed_python_module#338
Open
marcosbc wants to merge 1 commit intorpm-software-management:masterfrom
Open
Extend check for python_module to also support prefixed_python_module#338marcosbc wants to merge 1 commit intorpm-software-management:masterfrom
marcosbc wants to merge 1 commit intorpm-software-management:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates #321
We are using a variant of
python_modulewhich we have namedprefixed_python_module, given that we have the need of including a custom prefix in all our Python packages. The related contribution to python-rpm-macros can be found here.However, upon executing spec-cleaner on a recipe with a conditional BuildRequires which uses this macro, it will suggest a breaking change. For instance:
This has already been resolved for
python_modulevia #322, and we would like to propose for spec-cleaner also support this newprefixed_python_modulemacro that we are using.