Add check to prefer explicit lists over ~w and ~W sigils #1204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamu
commented
Jun 27, 2025
| issue = | ||
| format_issue( | ||
| issue_meta, | ||
| message: ~S{Avoid ~W sigil: ~W("foo" 'bar'), prefer explicit lists: [~S("foo"), "'bar'"]}, |
There was a problem hiding this comment.
This differs from the ~w example, because one of the reasons to use ~W is to avoid interpolating, so I wanted to include an example that does that.
|
I love this. I would enable this day 1 in all my repos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
This is a re-run of PR #1032 that I opened in March 2023, with the changes in response to the review comments from December 2023 😆
I responded to all the nits, but not the feature request because a) I'm not sure if it's needed and b) I don't really know how to do it, so it would take more time to figure out. I can still try it though, if you think it's required.