Add $filename command and test it (fix #23)
#31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Great! Documentation in README and presumably there's a use for this in the Cookbook? |
apt1002
force-pushed
the
issue23-filename
branch
2 times, most recently
from
b886332 to
d3f9649
Compare
Owner
|
Please can you rebase this PR, @apt1002 ? And check the setting here (I tried to rebase the PR but couldn't and suspect it's because you haven't allowed it): https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/configuring-commit-rebasing-for-pull-requests |
Collaborator
Author
|
I think the reason rebasing wasn't working is that I based this pull request off another. I've now rebased it on |
apt1002
force-pushed
the
issue23-filename
branch
3 times, most recently
from
8542cec to
74f1f29
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.