Skip to content

fix: prevent unnecessary error throwing in stringifyRule #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

megboehlert
Copy link

When a css import rule was being stringified (in stringifyRule) and the rule didn't have a styleSheet property at time of processing, an error would be thrown and passed up to stringifyStyleSheet where it was caught. Once caught, it would set null for the attributes._cssText property of the serializedNode. When watching the replay, these style elements would be empty instead of populated with the correct cssText.

Copy link

changeset-bot bot commented Apr 23, 2025

🦋 Changeset detected

Latest commit: df43bd6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
rrweb-snapshot Patch
rrweb Patch
rrdom Patch
rrdom-nodejs Patch
rrweb-player Patch
@rrweb/all Patch
@rrweb/replay Patch
@rrweb/record Patch
@rrweb/types Patch
@rrweb/packer Patch
@rrweb/utils Patch
@rrweb/web-extension Patch
rrvideo Patch
@rrweb/rrweb-plugin-console-record Patch
@rrweb/rrweb-plugin-console-replay Patch
@rrweb/rrweb-plugin-sequential-id-record Patch
@rrweb/rrweb-plugin-sequential-id-replay Patch
@rrweb/rrweb-plugin-canvas-webrtc-record Patch
@rrweb/rrweb-plugin-canvas-webrtc-replay Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@megboehlert megboehlert changed the title prevent unnecessary error throwing in stringifyRule fix: prevent unnecessary error throwing in stringifyRule Apr 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant