fix: prevent invalid media processing #1688
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 hello! i'm seeing
h.pause is not a function
errors/warnings during playback and after looking into the issue some more, it looks like during playback we can end up adding non-media elements to themediaMap
viamediaMutation
, which is what's causing some errors during playback.to summarize the changes in this pr:
addMediaElements
if a media element is blocked since it won't have any media attributes anyway