Fix #2429: Replaced slow UNION query with optimized all_objects query#2467
Open
LohithaNadimpalli wants to merge 1 commit intorsim:masterfrom
Open
Fix #2429: Replaced slow UNION query with optimized all_objects query#2467LohithaNadimpalli wants to merge 1 commit intorsim:masterfrom
LohithaNadimpalli wants to merge 1 commit intorsim:masterfrom
Conversation
Author
|
Hi maintainers! I'm a beginner contributor and excited to make my first PR to this project. Please let me know if anything needs improvement. 🙏 |
|
We've done some more research into this and found a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Replaced the slow UNION-based SQL query in
connection.rbwith a single query usingall_objectsto improve performance, as discussed in #2429.Details:
all_objects.Kindly review and let me know if further changes are needed.
Closes #2429