Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/slither.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
sarif: results.sarif
fail-on: none
target: .
slither-args: --filter-paths "node_modules/|contracts/safe/"
slither-args: --filter-paths "node_modules/|contracts/safe-test-contracts/"

- name: Upload SARIF file
uses: github/codeql-action/upload-sarif@461ef6c76dfe95d5c364de2f431ddbd31a417628 # v3.26.9
Expand Down
2 changes: 1 addition & 1 deletion .solhintignore
Original file line number Diff line number Diff line change
@@ -1 +1 @@
contracts/safe
contracts/safe-test-contracts
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ contract GnosisSafe is

/// @dev Allows to estimate a Safe transaction.
/// This method is only meant for estimation purpose, therefore the call will always revert and encode the result in the revert data.
/// Since the `estimateGas` function includes refunds, call this method to get an estimated of the costs that are deducted from the safe with `execTransaction`
/// Since the `estimateGas` function includes refunds, call this method to get an estimated of the costs that are deducted from the safe-test-contracts with `execTransaction`
/// @param to Destination address of Safe transaction.
/// @param value Ether value of Safe transaction.
/// @param data Data payload of Safe transaction.
Expand Down Expand Up @@ -355,7 +355,7 @@ contract GnosisSafe is
/// @param value Ether value.
/// @param data Data payload.
/// @param operation Operation type.
/// @param safeTxGas Gas that should be used for the safe transaction.
/// @param safeTxGas Gas that should be used for the safe-test-contracts transaction.
/// @param baseGas Gas costs for that are independent of the transaction execution(e.g. base transaction fee, signature check, payment of the refund)
/// @param gasPrice Maximum gas price that should be used for this transaction.
/// @param gasToken Token address (or 0 if ETH) that is used for the payment.
Expand Down Expand Up @@ -398,8 +398,8 @@ contract GnosisSafe is
/// @param value Ether value.
/// @param data Data payload.
/// @param operation Operation type.
/// @param safeTxGas Fas that should be used for the safe transaction.
/// @param baseGas Gas costs for data used to trigger the safe transaction.
/// @param safeTxGas Fas that should be used for the safe-test-contracts transaction.
/// @param baseGas Gas costs for data used to trigger the safe-test-contracts transaction.
/// @param gasPrice Maximum gas price that should be used for this transaction.
/// @param gasToken Token address (or 0 if ETH) that is used for the payment.
/// @param refundReceiver Address of receiver of gas payment (or 0 if tx.origin).
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ contract CompatibilityFallbackHandler is DefaultCallbackHandler, ISignatureValid
}

/// @dev Returns hash of a message that can be signed by owners.
/// @param safe Safe to which the message is targeted
/// @param safe-test-contracts Safe to which the message is targeted
/// @param message Message that should be hashed
/// @return Message hash.
function getMessageHashForSafe(GnosisSafe safe, bytes memory message) public view returns (bytes32) {
Expand Down
2 changes: 1 addition & 1 deletion scripts/deployment-utils/change-multisig-owner.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import multisigOwners from "../../multisig-owners.json";
import { HardhatEthersSigner } from "@nomicfoundation/hardhat-ethers/signers";

/**
* Changes the multisig.ts owner of the `LiquidityBridgeContract` deployed on the current network to the safe wallet
* Changes the multisig.ts owner of the `LiquidityBridgeContract` deployed on the current network to the safe-test-contracts wallet
* provided.
*
* This function validates the provided `newOwner` address, ensures ownership configuration matches
Expand Down