Feature/GBI-2806 - Discovery & Collateral Management

[Luisfc68]

What

• Update solidity compiler version of the contracts to 0.8.25
• Update hardhat version to 2.25.0
• Update OZ contracts version to 5.3.0
• Remove some getters from LiquidityBridgeContractV2 to be able to fit the max size with the new version of the OZ contracts
• Added 2 versions of Flyover Discovery split (version with everything in the same contract and version with one contract for Discovery and one contract for CollateralManagement)
• Added test executing all the functions where Discovery and CollateralManagement interact
  • register
  • isOperational
  • getProviders
• Added gas report of the execution of the previously mentioned test from 1 to 5 liquidity providers in the contract

What is NOT in this PR and will be added later

• Linter adjustments for the new contracts (will be added once we decide on the version)
• NatSpec documentation for the new contracts (will be added once we decide on the version)
• Tests for the new contracts (the current test suite will be adapted to run in the split version in a separate task, also once we decide on the implementation that contract will have its own suite)

The purpose of this PR is only to gather information to decide if we go with 3 or 4 contracts

Task

https://rsklabs.atlassian.net/browse/GBI-2806

[github-actions]

Dependency Review

The following issues were found:

• ✅ 0 vulnerable package(s)
• ✅ 0 package(s) with incompatible licenses
• ✅ 0 package(s) with invalid SPDX license definitions
• ✅ 0 package(s) with unknown licenses.
• ⚠️ 5 packages with OpenSSF Scorecard issues.

View full job summary

[Copilot]

Pull Request Overview

This PR updates core dependencies and compiler settings, introduces a split between discovery and collateral management contracts (along with benchmarks and gas reports), and adapts tests to the new APIs.

• Bump Solidity compiler to 0.8.25, Hardhat to 2.25.0, and OpenZeppelin contracts to v5.3.0; remove some legacy getters.
• Add split implementations (FlyoverDiscoveryFull, FlyoverDiscoveryContract, CollateralManagementContract) and related interfaces.
• Introduce a benchmark test with gas reporting and update existing tests to use new contract methods.

Reviewed Changes

Copilot reviewed 26 out of 28 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
test/utils/fixtures.ts	Switched from getBridgeAddress() to auto-generated .bridge()
test/pegin.test.ts	Updated hardcoded addresses for pegin test cases
test/discovery.test.ts	Replaced getProviderIds() with the new .providerId() getter
test/benchmark.test.ts	Added a comprehensive benchmark suite with console logging
package.json	Bumped devDependencies and dependencies versions
hardhat.config.ts	Updated Solidity version and added gasReporter configuration
e2e/multisig-migration.test.ts	Switched to upgradeAndCall in upgrade tests
docs/discovery-report.md	New gas usage report for different LP counts
contracts/split/interfaces.sol	New shared types and errors for split contracts
contracts/split/FlyoverDiscoveryFull.sol	Full discovery+collateral contract
contracts/split/FlyoverDiscovery.sol	Discovery-only contract
contracts/split/CollateralManagement.sol	Collateral management contract
contracts/**/*.sol	Updated pragma to 0.8.25 across all Solidity files
.solhint.json	Updated compiler-version rule to 0.8.25

Comments suppressed due to low confidence (2)

test/benchmark.test.ts:181

• This benchmark logs the output but has no assertions against expected values; consider adding checks to validate behavior rather than relying solely on console output.

    const discoveryProviders = await discovery.getProviders();

test/discovery.test.ts:27

• [nitpick] Using a method named providerId() may be unclear—consider renaming the underlying state variable or providing a more descriptive getter like lastProviderId() for consistency.

    const lastProviderId = await lbc.providerId();