Skip to content

Feature/GBI-2808 - PegOut Contract implementation #349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Luisfc68 merged 13 commits into from
Aug 13, 2025

fix: copilot suggestions

f1fd36f
Select commit
Loading
Failed to load commit list.
Merged

Feature/GBI-2808 - PegOut Contract implementation #349

fix: copilot suggestions
f1fd36f
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither succeeded Aug 5, 2025 in 4s

10 new alerts including 3 low severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 3 low

Other Alerts:

  • 7 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 70 in contracts/DaoContributor.sol

See this annotation in the file changed.

Code scanning / Slither

Low-level calls Warning

Low level call in OwnableDaoContributorUpgradeable.claimContribution():
- (sent,reason) = feeCollector.call{value: amount}()

Check warning on line 120 in contracts/DaoContributor.sol

See this annotation in the file changed.

Code scanning / Slither

Conformance to Solidity naming conventions Warning

Function OwnableDaoContributorUpgradeable.__OwnableDaoContributor_init(address,uint256,address) is not in mixedCase

Check warning on line 141 in contracts/DaoContributor.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

OwnableDaoContributorUpgradeable._getContributorStorage() uses assembly
- INLINE ASM

Check notice on line 107 in contracts/PegOutContract.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

PegOutContract.depositPegOut(Quotes.PegOutQuote,bytes) uses timestamp for comparisons
Dangerous comparisons:
- quote.depositDateLimit < block.timestamp || quote.expireDate < block.timestamp

Check warning on line 107 in contracts/PegOutContract.sol

See this annotation in the file changed.

Check warning on line 205 in contracts/PegOutContract.sol

See this annotation in the file changed.

Check notice on line 228 in contracts/PegOutContract.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

PegOutContract.refundUserPegOut(bytes32) uses timestamp for comparisons
Dangerous comparisons:
- quote.expireDate >= block.timestamp || quote.expireBlock >= block.number

Check warning on line 228 in contracts/PegOutContract.sol

See this annotation in the file changed.

Code scanning / Slither

Low-level calls Warning

Low level call in PegOutContract.refundUserPegOut(bytes32):
- (sent,reason) = addressToTransfer.call{value: valueToTransfer}()

Check notice on line 294 in contracts/PegOutContract.sol

See this annotation in the file changed.

Code scanning / Slither

Block timestamp Low

PegOutContract._shouldPenalize(Quotes.PegOutQuote,bytes32,bytes32) uses timestamp for comparisons
Dangerous comparisons:
- block.timestamp > quote.expireDate || block.number > quote.expireBlock

Check warning on line 371 in contracts/PegOutContract.sol

See this annotation in the file changed.

Code scanning / Slither

Assembly usage Warning

PegOutContract._validateBtcTxNullData(BtcUtils.TxRawOutput[],bytes32) uses assembly
- INLINE ASM