Skip to content

Feature/GBI-2807 - PegIn contract #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alexjavabraz merged 14 commits into from
Aug 25, 2025

fix: add reentrancy check in getQuoteStatus view

daa49a2
Select commit
Loading
Failed to load commit list.
Merged

Feature/GBI-2807 - PegIn contract #354

fix: add reentrancy check in getQuoteStatus view
daa49a2
Select commit
Loading
Failed to load commit list.
GitHub Advanced Security / Slither failed Aug 25, 2025 in 6s

12 new alerts including 4 high severity security vulnerabilities

New alerts in code changed by this pull request

Security Alerts:

  • 4 high
  • 1 medium
  • 3 low

Other Alerts:

  • 4 warnings

See annotations below for details.

View all branch alerts.

Annotations

Check warning on line 149 in contracts/PegInContract.sol

See this annotation in the file changed.

Code scanning / Slither

Low-level calls Warning

Low level call in PegInContract.withdraw(uint256):
- (success,reason) = msg.sender.call{value: amount}()

Check failure on line 200 in contracts/PegInContract.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities High

Reentrancy in PegInContract.callForUser(Quotes.PegInQuote):
External calls:
- (success,None) = quote.contractAddress.call{gas: quote.gasLimit,value: quote.value}(quote.data)
State variables written after the call(s):
- _decreaseBalance(quote.liquidityProviderRskAddress,quote.value)
- _balances[dest] -= amount
PegInContract._balances can be used in cross function reentrancies:
- PegInContract.getBalance(address)

Check notice on line 200 in contracts/PegInContract.sol

See this annotation in the file changed.

Code scanning / Slither

Return Bomb Low

PegInContract.callForUser(Quotes.PegInQuote) tries to limit the gas of an external call that controls implicit decoding
(success,None) = quote.contractAddress.call{gas: quote.gasLimit,value: quote.value}(quote.data)

Check warning on line 200 in contracts/PegInContract.sol

See this annotation in the file changed.

Check warning on line 246 in contracts/PegInContract.sol

See this annotation in the file changed.

Code scanning / Slither

Reentrancy vulnerabilities Medium

Reentrancy in PegInContract.registerPegIn(Quotes.PegInQuote,bytes,bytes,bytes,uint256):
External calls:
- registerResult = _registerBridge(quote,btcRawTransaction,partialMerkleTree,height,quoteHash)
- _bridge.registerFastBridgeBtcTransaction(btcRawTransaction,height,partialMerkleTree,derivationHash,quote.btcRefundAddress,address(this),quote.liquidityProviderBtcAddress,callRegistry.timestamp > 0 && callRegistry.success)
- _collateralManagement.slashPegInCollateral(msg.sender,quote,quoteHash)
State variables written after the call(s):
- _processedQuotes[quoteHash] = PegInStates.PROCESSED_QUOTE
PegInContract._processedQuotes can be used in cross function reentrancies:
- PegInContract.getQuoteStatus(bytes32)
- _processedQuotes[quoteHash] = PegInStates.PROCESSED_QUOTE
PegInContract._processedQuotes can be used in cross function reentrancies:
- PegInContract.getQuoteStatus(bytes32)

Check failure on line 392 in contracts/PegInContract.sol

See this annotation in the file changed.

Code scanning / Slither

Functions that send Ether to arbitrary destinations High

PegInContract._registerCallDone(Quotes.PegInQuote,bytes32,bool,uint256) sends eth to arbitrary user
Dangerous calls:
- (success,None) = quote.rskRefundAddress.call{gas: _MAX_REFUND_GAS_LIMIT,value: remainingAmount}()

Check failure on line 392 in contracts/PegInContract.sol

See this annotation in the file changed.

Check notice on line 392 in contracts/PegInContract.sol

See this annotation in the file changed.

Code scanning / Slither

Return Bomb Low

PegInContract._registerCallDone(Quotes.PegInQuote,bytes32,bool,uint256) tries to limit the gas of an external call that controls implicit decoding
(success,None) = quote.rskRefundAddress.call{gas: _MAX_REFUND_GAS_LIMIT,value: remainingAmount}()

Check warning on line 392 in contracts/PegInContract.sol

See this annotation in the file changed.

Check failure on line 443 in contracts/PegInContract.sol

See this annotation in the file changed.

Check notice on line 443 in contracts/PegInContract.sol

See this annotation in the file changed.

Check warning on line 443 in contracts/PegInContract.sol

See this annotation in the file changed.