Skip to content

GBI-2875/signature-length-verification#359

Merged
Luisfc68 merged 5 commits intolbc-splitfrom
GBI-2875/signature-length-verification
Sep 25, 2025
Merged

GBI-2875/signature-length-verification#359
Luisfc68 merged 5 commits intolbc-splitfrom
GBI-2875/signature-length-verification

Conversation

@Hakob23
Copy link
Copy Markdown
Collaborator

@Hakob23 Hakob23 commented Sep 11, 2025

The Task

What

  • Add a signature length verification

Why

  • To avoid unexpected behavior during the verification process, and in the worst case scenario, verification of a malicious signature.

How to Test

npm run test -- test/signature-validator.test.ts

Copy link
Copy Markdown

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slither found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

@Hakob23 Hakob23 changed the base branch from master to lbc-split September 11, 2025 10:31
@github-actions
Copy link
Copy Markdown

github-actions bot commented Sep 11, 2025

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

@Hakob23 Hakob23 marked this pull request as ready for review September 11, 2025 10:35
@Hakob23 Hakob23 self-assigned this Sep 18, 2025
@Luisfc68 Luisfc68 merged commit 10b14d1 into lbc-split Sep 25, 2025
5 checks passed
@Luisfc68 Luisfc68 deleted the GBI-2875/signature-length-verification branch September 25, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants