Fly 1130/pegout validation extension#372
Merged
Merged
Conversation
…ation, enhancing the PegOutContract. This function allows liquidity providers to verify Bitcoin transactions without requiring confirmations. Refactor existing validation logic into a private method for reuse. Add comprehensive tests to ensure correct behavior and error handling for various scenarios.
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Luisfc68
requested changes
Nov 20, 2025
| // Test that a malformed Bitcoin transaction (too short) reverts | ||
| // Using a minimal invalid tx hex"010203" instead of properly formed tx | ||
| vm.prank(pegOutLp); | ||
| vm.expectRevert(); // MalformedTransaction |
Collaborator
There was a problem hiding this comment.
you're not asserting the error type
| bytes memory btcTx = generateBtcTx(wrongAddressQuote, quoteHash); | ||
|
|
||
| vm.prank(pegOutLp); | ||
| vm.expectRevert(); // InvalidDestination |
Collaborator
There was a problem hiding this comment.
you're not asserting the error type
| assertEq(returnedQuote.lbcAddress, quote.lbcAddress); | ||
| } | ||
|
|
||
| function test_ValidatePegout_DoesNotRequireConfirmations() public { |
Collaborator
There was a problem hiding this comment.
isn't this test the same as the one above?
15 tasks
Luisfc68
approved these changes
Dec 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The task
Why
The idea of this task is to add a new function to the
PegOutContractwhich receives the transaction that is going to be used to callrefundPegOutand validate if its ok