Adding Invariant Tests

[Hakob23]

What

Adding invariant tests, including both isolated and integrated test suites.
The changes include

• addition of an isolated test suite for discoveryContract
• addition of SystemInvariant test suite for integrated invariant testing
• addition of handler contracts for all invariant tests
• refactoring of invariant tests to use the handlers

Task

https://rsklabs.atlassian.net/browse/FLY-2167

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details
npm/@rsksmart/btc-transaction-solidity-helper	0.3.0-beta	🟢 6.5	Details Check Score Reason Binary-Artifacts 🟢 10 no binaries found in the repo Branch-Protection 🟢 8 branch protection is not maximal on development and all release branches CI-Tests 🟢 10 14 out of 14 merged PRs checked by a CI test -- score normalized to 10 CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Code-Review 🟢 3 Found 5/14 approved changesets -- score normalized to 3 Contributors 🟢 3 project has 1 contributing companies or organizations -- score normalized to 3 Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Dependency-Update-Tool 🟢 10 update tool detected Fuzzing ⚠️ 0 project is not fuzzed License 🟢 10 license file detected Maintained ⚠️ 0 0 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0 Packaging ⚠️ -1 packaging workflow not detected Pinned-Dependencies 🟢 10 all dependencies are pinned SAST 🟢 8 SAST tool is not run on all commits -- score normalized to 8 Security-Policy 🟢 10 security policy file detected Signed-Releases ⚠️ -1 no releases found Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege Vulnerabilities ⚠️ 0 14 existing vulnerabilities detected

Scanned Files

• package-lock.json

[Luisfc68]

The PR is approved, my comments are more related to the definition of some invariants, but not to the code itself, I think the discussion about the invariants should be taken separately as its not so simple, but as PoC the code LGTM

[Copilot]

Pull request overview

Adds a suite of Foundry invariant tests (isolated + integrated) for the Flyover system, refactoring invariant interactions through dedicated handler contracts, and includes a small PegInContract refactor to remove an opcode import dependency.

Changes:

• Introduces invariant handler contracts for Discovery, CollateralManagement, PegIn, PegOut, and a cross-contract System handler.
• Adds/updates invariant test suites to use the handlers, including a new integrated SystemInvariantTest.
• Updates Foundry invariant configuration (runs, depth, fail_on_revert) and removes OpCodes import usage in PegInContract.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
test/invariant/handlers/HandlerBase.sol	Shared utilities/constants for invariant handlers (quote staging, bookkeeping helpers).
test/invariant/handlers/DiscoveryHandler.sol	Fuzzable actions for Discovery invariant testing (register/toggle/update).
test/invariant/handlers/CollateralHandler.sol	Fuzzable actions for CollateralManagement invariant testing (add/slash/resign/withdraw).
test/invariant/handlers/PegInHandler.sol	Fuzzable actions for PegIn invariant testing (deposit/withdraw + LP tracking).
test/invariant/handlers/PegOutHandler.sol	Fuzzable actions for PegOut invariant testing (deposit/refund/withdraw + active quote tracking).
test/invariant/handlers/SystemHandler.sol	Cross-contract fuzzable actions + system-level ghost accounting.
test/invariant/DiscoveryInvariant.t.sol	New Discovery invariants wired to DiscoveryHandler.
test/invariant/CollateralInvariant.t.sol	Refactors Collateral invariants to use CollateralHandler and adds conservation assertions.
test/invariant/PegInInvariant.t.sol	Refactors PegIn invariants to use PegInHandler and tightens accounting checks.
test/invariant/PegOutInvariant.t.sol	Refactors PegOut invariants to use PegOutHandler and expands accounting invariants.
test/invariant/SystemInvariant.t.sol	New integrated/system invariant suite covering cross-contract solvency + conservation.
src/PegInContract.sol	Replaces OpCodes constants usage with locally defined opcode bytes.
foundry.toml	Adds [invariant] configuration for invariant runs/depth/revert behavior.

---

You can also share your feedback on Copilot code review. Take the survey.