Feature/fly 2232

[Hakob23]

What

Implement Hard and Soft Pause functionality, and add corresponding test cases

The Task

https://rsklabs.atlassian.net/browse/FLY-2232?atlOrigin=eyJpIjoiZDUwNzE3ODY3OTUxNDk5NmFhMDFmOWEwOTg5MmMwY2EiLCJwIjoiaiJ9

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 0fe3c05.

Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

Package	Version	Score	Details
npm/@rsksmart/btc-transaction-solidity-helper	0.3.0-beta	🟢 6.5	Details Check Score Reason Binary-Artifacts 🟢 10 no binaries found in the repo Branch-Protection 🟢 8 branch protection is not maximal on development and all release branches CI-Tests 🟢 10 14 out of 14 merged PRs checked by a CI test -- score normalized to 10 CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Code-Review 🟢 3 Found 5/14 approved changesets -- score normalized to 3 Contributors 🟢 3 project has 1 contributing companies or organizations -- score normalized to 3 Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Dependency-Update-Tool 🟢 10 update tool detected Fuzzing ⚠️ 0 project is not fuzzed License 🟢 10 license file detected Maintained ⚠️ 0 0 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0 Packaging ⚠️ -1 packaging workflow not detected Pinned-Dependencies 🟢 10 all dependencies are pinned SAST 🟢 8 SAST tool is not run on all commits -- score normalized to 8 Security-Policy 🟢 10 security policy file detected Signed-Releases ⚠️ -1 no releases found Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege Vulnerabilities ⚠️ 0 14 existing vulnerabilities detected

Scanned Files

• package-lock.json

[Copilot]

Pull request overview

This PR introduces a two-level emergency pause system (soft vs. hard) across Flyover contracts, adds hard-pause window accounting for time/block-based expirations, and updates tests to validate the new pause semantics.

Changes:

• Add pause levels (0/1/2) and hard-pause window tracking/overlap computation in PauseRegistry.
• Update core contracts to differentiate “no new business” (soft pause) vs “full freeze” (hard pause) via new modifiers.
• Extend pause-related tests to cover level behavior and hard-pause overlap logic.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
test/tasks/PauseSystem.t.sol	Updates mock pause registry to satisfy the expanded IPauseRegistry interface.
test/Pause.t.sol	Adjusts pause reason expectations and adds tests for soft/hard pause behavior and overlap calculations.
src/PegOutContract.sol	Applies soft/hard pause modifiers; adjusts expiry/penalty logic to account for hard-pause overlap and records deposit block.
src/PegInContract.sol	Applies soft/hard pause modifiers; adjusts slashing timing logic to account for hard-pause overlap.
src/PauseRegistry.sol	Implements pause levels, hard-pause logging, and overlap computation helpers.
src/interfaces/IPauseRegistry.sol	Extends interface with pause levels and overlap APIs.
src/FlyoverDiscovery.sol	Switches registration to soft pause and provider updates to hard pause gating.
src/EmergencyPause/EmergencyPause.sol	Replaces single pause modifier with soft/hard pause modifiers.
src/CollateralManagement.sol	Gates “new business” actions on soft pause and withdrawals/resign on hard pause; excludes hard-pause blocks from resignation delay.

Comments suppressed due to low confidence (1)

src/EmergencyPause/EmergencyPause.sol:40

• The new whenNotSoftPaused/whenNotHardPaused modifiers replace the old whenNotPaused, but the module-level docstring and related comments still refer to whenNotPaused. This is now misleading for maintainers/users of EmergencyPause; update the documentation to reference the new modifier names and semantics (soft vs hard).

    /// @notice Reverts at pause level >= 1 (soft pause: no new business)
    modifier whenNotSoftPaused() {
        if (_getEmergencyPauseStorage().pauseRegistry.pauseLevel() > 0) {
            revert Flyover.EnforcedPause();
        }
        _;
    }

    /// @notice Reverts at pause level >= 2 (hard pause: full freeze)
    modifier whenNotHardPaused() {
        if (_getEmergencyPauseStorage().pauseRegistry.pauseLevel() > 1) {
            revert Flyover.EnforcedPause();
        }
        _;
    }

---

You can also share your feedback on Copilot code review. Take the survey.

[alexjavabraz]

LGTM