Test/fly 2238

[Hakob23]

What

The idea is to compare the new version of the contract(s) with currently deployed version of the contract(s) to make sure they are behaving the same way for given scenarios as expected(unless if there is an intentional behavioral change of course).

To make the test suite as resilient to radical architectural changes as possible(as v2.5.0 is for example), an adapter was introduced to normalize the layouts between the current and new versions. The PR covers some simple test cases and also the skeleton of more test cases that could be covered as a suggestion for future development. The tests are network agnostic, as the later is handled via Helper config(in case if some of the networks have an external problem when trying to fork).

The task

https://rsklabs.atlassian.net/browse/FLY-2238?atlOrigin=eyJpIjoiMWRkZDE1NzgzMWY2NGQ1NGJkZDg4Nzg3Yjg5ZjAzYzYiLCJwIjoiaiJ9

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details
npm/@rsksmart/btc-transaction-solidity-helper	0.3.0-beta	🟢 6.5	Details Check Score Reason Binary-Artifacts 🟢 10 no binaries found in the repo Branch-Protection 🟢 8 branch protection is not maximal on development and all release branches CI-Tests 🟢 10 14 out of 14 merged PRs checked by a CI test -- score normalized to 10 CII-Best-Practices ⚠️ 0 no effort to earn an OpenSSF best practices badge detected Code-Review 🟢 3 Found 5/14 approved changesets -- score normalized to 3 Contributors 🟢 3 project has 1 contributing companies or organizations -- score normalized to 3 Dangerous-Workflow 🟢 10 no dangerous workflow patterns detected Dependency-Update-Tool 🟢 10 update tool detected Fuzzing ⚠️ 0 project is not fuzzed License 🟢 10 license file detected Maintained ⚠️ 0 0 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 0 Packaging ⚠️ -1 packaging workflow not detected Pinned-Dependencies 🟢 10 all dependencies are pinned SAST 🟢 8 SAST tool is not run on all commits -- score normalized to 8 Security-Policy 🟢 10 security policy file detected Signed-Releases ⚠️ -1 no releases found Token-Permissions 🟢 10 GitHub workflow tokens follow principle of least privilege Vulnerabilities ⚠️ 0 14 existing vulnerabilities detected

Scanned Files

• package-lock.json

[Copilot]

Pull request overview

Adds a new differential testing harness intended to compare behavior between the currently deployed legacy Flyover (reference) and the new split-contract Flyover (candidate) on a fork, using adapters to normalize the APIs.

Changes:

• Introduce DifferentialBase harness to fork a configured network, resolve deployed reference addresses, and deploy a split candidate locally.
• Add adapter layer (IDifferentialAdapter, ReferenceAdapter, CandidateAdapter) to provide a unified interface for reference/candidate calls.
• Add initial differential tests (plus TODO skeletons), and add a deployForTesting helper in DeployFlyover to support test deployments.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
test/differential/base/DifferentialBase.sol	Fork/bootstrap harness and candidate deployment based on reference config
test/differential/adapters/IDifferentialAdapter.sol	Unified adapter interface for differential comparisons
test/differential/adapters/ReferenceAdapter.sol	Adapter over deployed legacy reference contract
test/differential/adapters/CandidateAdapter.sol	Adapter over newly deployed split candidate contracts
test/differential/DifferentialParity.diff.t.sol	Initial non-fuzz differential tests + skeletons
test/differential/DifferentialParity.fuzz.diff.t.sol	Fuzz test skeletons
script/deployment/DeployFlyover.s.sol	Adds deployForTesting helper for test deployments
script/HelperConfig.s.sol	Adds differential-network selection config resolver
example.env	Documents DIFF_NETWORK env var

---

You can also share your feedback on Copilot code review. Take the survey.

[Luisfc68]

approved but pls take a look to my only comment (also check copilot ones according to your criteria)