feat: added pegout report endpoint#661
Merged
gsoares85 merged 1 commit intofeature/addPeginReportEndpointfrom Mar 21, 2025
Merged
feat: added pegout report endpoint#661gsoares85 merged 1 commit intofeature/addPeginReportEndpointfrom
gsoares85 merged 1 commit intofeature/addPeginReportEndpointfrom
Conversation
gsoares85
requested review from
AndresQuijano,
Dominikkq,
Luisfc68 and
MaximStanciu8
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
MaximStanciu8
approved these changes
Mar 17, 2025
Luisfc68
approved these changes
Mar 21, 2025
Collaborator
Luisfc68
left a comment
Luisfc68
left a comment
There was a problem hiding this comment.
The code looks fine, but I'd like to remind a couple things:
- Now we're adding tests to the http handlers as well so they should be included in the PRs too
- These reports endpoint don't consider the gas fee nor the actual gas cost of the different transactions. This will make their results inaccurate, specially in the long term
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
###What
Added a new endpoint under management API to return a financial report over the pegouts.
Number of Quotes Finalized -> Only the ones with the status RegisterPegOutSucceeded
Minimum and maximum Value for the quotes
Average Value
Total Call Fess
Average Call Fess
Already added the average call fees since we have plans to move to a percentage fee
Task
https://rsklabs.atlassian.net/browse/GBI-2539