Feature/add pegin report endpoint#673
Merged
Luisfc68 merged 16 commits intoflyover-2.3.0from Apr 30, 2025
Merged
Conversation
feat: added pegout report endpoint
gsoares85
requested review from
AndresQuijano,
Dominikkq,
Luisfc68 and
MaximStanciu8
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
Luisfc68
reviewed
Apr 7, 2025
internal/adapters/entrypoints/rest/handlers/get_reports_pegin.go
Outdated
Show resolved
Hide resolved
MaximStanciu8
approved these changes
Apr 8, 2025
MaximStanciu8
approved these changes
Apr 8, 2025
Luisfc68
requested changes
Apr 11, 2025
internal/adapters/entrypoints/rest/handlers/get_reports_pegin.go
Outdated
Show resolved
Hide resolved
Luisfc68
requested changes
Apr 22, 2025
Collaborator
Luisfc68
left a comment
Luisfc68
left a comment
There was a problem hiding this comment.
I think the general idea of the approach related to the query to the db is correct because its similar to the criteria pattern which is the proper solution for this kind of scenarios. However the implementation has multiple things to improve, it lacks of type safety and operands abstracted from the db. My recommendation is to address the comments and we can assume the proper implementation of criteria pattern as technical debt, because this PR has been pending for a long time.
Luisfc68
approved these changes
Apr 30, 2025
| AverageFeePerQuote: entities.NewWei(0), | ||
| } | ||
|
|
||
| states := []quote.PegoutState{quote.PegoutStateRefundPegOutSucceeded} |
Collaborator
There was a problem hiding this comment.
this is not the last step of the pegout
| retainedQuotes, err := useCase.pegoutQuoteRepository.GetRetainedQuoteByState(ctx, states...) | ||
|
|
||
| if err != nil { | ||
| return GetPegoutReportResult{}, usecases.WrapUseCaseError(usecases.GetPeginReportId, err) |
Collaborator
There was a problem hiding this comment.
the use case id is the pegin one
Collaborator
There was a problem hiding this comment.
in the rest of the file too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved to the new branch, since financial reports will go only on version 2.3.0