Financial API + ManagementUI [GBI-2537]#676
Closed
Dominikkq wants to merge 22 commits intoflyover-2.3.0from
Closed
Financial API + ManagementUI [GBI-2537]#676Dominikkq wants to merge 22 commits intoflyover-2.3.0from
Dominikkq wants to merge 22 commits intoflyover-2.3.0from
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
There was a problem hiding this comment.
Copilot reviewed 21 out of 24 changed files in this pull request and generated 1 comment.
Files not reviewed (3)
- OpenApi.yml: Language not supported
- internal/adapters/entrypoints/rest/assets/management.html: Language not supported
- internal/adapters/entrypoints/rest/assets/static/management.css: Language not supported
Comments suppressed due to low confidence (1)
internal/usecases/liquidity_provider/summaries.go:211
- [nitpick] Consider renaming 'quoteCopy' to a more descriptive name (e.g., 'currentQuote') and adding a comment to clarify that a copy is taken to avoid pointer aliasing issues.
quoteCopy := quotes[index]
Dominikkq
requested review from
AndresQuijano,
Luisfc68,
MaximStanciu8 and
gsoares85
Luisfc68
requested changes
Apr 9, 2025
Collaborator
Luisfc68
left a comment
Luisfc68
left a comment
There was a problem hiding this comment.
The PR still needs multiple changes, there are functions with too much responsibility, the interface usage is not correct in multiple cases and the boundaries in the layers of the project are broken on some points
MaximStanciu8
approved these changes
Apr 10, 2025
* feedback:SummaryData types * feedback:Rename SummariesResponse & move interfaces to common * feedback:isAcceptedPegin/isAcceptedPegout * feedback:QuoteHashToIndex * feedback:Remove unnecessary mocks * feedback:improve summaries.go * feedback:Common & GetReportSummaries * feedback:Common.go * feedback:QuoteHashProvider * feedback:cleanup * feedback:Remove PegoutQuoteResult/PeginQuoteResult * feedback:mock cleanup * feedback:update isPegoutRefundedQuote * feedback:cleanup
Luisfc68
reviewed
Apr 24, 2025
Collaborator
Luisfc68
left a comment
Luisfc68
left a comment
There was a problem hiding this comment.
We used this PR to start making synchronous code reviews, the comments added were the ones discussed during the meeting, they might not reflect all the final comments
Luisfc68
requested changes
May 20, 2025
Luisfc68
requested changes
May 29, 2025
Luisfc68
approved these changes
May 30, 2025
Luisfc68
reviewed
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Added /report/summaries endpoint
Implemented date validation for query parameters
Added ListQuotesByDateRange functionality
Added SummariesUseCase to process and aggregate liquidity provider data
Added "Reports" card to Management UI with date selection and summary tables
Implemented test coverage with mocks for all new components
Task
GBI-2537