feedback:FinancialAPI#677
Merged
Dominikkq merged 14 commits intofeat-financial-summaryfrom Apr 11, 2025
Merged
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
There was a problem hiding this comment.
Copilot reviewed 16 out of 17 changed files in this pull request and generated 2 comments.
Files not reviewed (1)
- OpenApi.yml: Language not supported
Comments suppressed due to low confidence (2)
internal/adapters/dataproviders/database/mongo/pegout.go:357
- The previous implementation fetched additional quotes using the additional quote hashes, but this logic has been removed. Ensure that this behavior change is intentional.
if len(quoteHashes) > 0 { ... }
internal/adapters/dataproviders/database/mongo/pegin.go:219
- Similar to pegout, converting the Unix timestamp to uint32 in the Pegin adapter may truncate dates beyond 2038. Consider using int64 to preserve the full timestamp range.
startTimestamp := uint32(startDate.Unix())
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.