Feat FLY2217 prioritize pegin contract funds in hot-to-cold transfers

[AndresQuijano]

What

Gives priority to the funds in the contract when transferring funds from RSK hot to cold wallet.

Why

Avoid creating a honeypot in the contract.

Note

Depends on #925

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change
• Documentation update
• Refactoring (no functional changes, no api changes)
• Performance improvement
• Test updates
• Security fix
• Deployment/Infrastructure changes

Affected part of the project

• Management UI / API
• PegIn flow
• PegOut flow
• Utility scripts
• Configuration files
• Metrics and alerting
• Hot to cold wallet flow

Related Issues

Jira ticket FLY-2217

How to test

This is my suggestion:

1. Start the local env without the LPS
2. Modify internal/adapters/entrypoints/watcher/common.go so transferColdWalletInterval is 1 minute or even 30 seconds.
3. Check the balance of the contract for the LPS (must be 0)

cast call --rpc-url http://localhost:4444 \
  0x8901a2Bbf639bFD21A97004BA4D7aE2BD00B8DA8 \
  "getBalance(address)(uint256)" \
  0x9D93929A9099be4355fC2389FbF253982F9dF47c

4. Deposit some funds

cast send \
  --rpc-url http://localhost:4444 \
  --private-key 0x87ce4239eef3d02cf31223490cd686f6a3d2d338af58646ea36be24c04a926b2 \
  0x8901a2Bbf639bFD21A97004BA4D7aE2BD00B8DA8 \
  "deposit()" \
  --value 0.5ether \
  --legacy

5. Verify they landed with the same command on step 3
6. Start the LPS in local without docker
7. Check the log and look for something like this:
   INFO[0030] TransferExcessToColdWallet: withdrawing 500000000000000000 wei from pegin contract
   INFO[0030] Executing Withdraw transaction...
   INFO[0030] Transaction Withdraw (0x2bf548a547adbb4ba21a752936e2dba09dd4ff853531c38dc30769d72ed17694) executed successfully
8. Check again the balance in the contract with the same command on step 3.

[github-actions]

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

Package	Version	Score	Details

Scanned Files