Powpeg refactors integration#572
Open
julia-zack wants to merge 8 commits into
Open
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
julia-zack
commented
Apr 28, 2026
Comment on lines
-59
to
-61
| // add proposed federation to active btc to rsk client so | ||
| // it can register svp spend tx in the bridge | ||
| bitcoinWrapper.addFederationListener(newProposedFederation, btcToRskClientActive); |
Contributor
Author
There was a problem hiding this comment.
svp spend tx will be registered by active feds. We don't need the proposed ones to do it
julia-zack
force-pushed
the
powpeg-refactors-integration
branch
from
b685248 to
1cf3fe0
Compare
julia-zack
force-pushed
the
powpeg-refactors-integration
branch
from
1cf3fe0 to
f314ae8
Compare
julia-zack
changed the base branch from
master
to
different-proofs-file-for-different-clients
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove some rskj dependencies: new
BTC_TO_RSK_MINIMUM_ACCEPTABLE_CONFIRMATIONS_ON_RSKfield; newPegUtilsclass.BitcoinWrapperImpl: remove peg filtering from which txs are listened (thats client logic).FederationWatcherListenerImpl: remove proposed-federation listener on active BTC→RSK client (SVP spend registration handled by active federations)Tests: added new test cases, remove (now wrong) old test cases
rit:powpeg-refactors-integrationrskj:powpeg-refactors-integrationfed:powpeg-refactors-integration