feat(cli): add simulate command for testing RBTC and ERC20 transfers … by Ad-Capital · Pull Request #288 · rsksmart/rsk-cli

Ad-Capital · 2025-11-09T20:03:46Z

…with gas estimation, balance validation, cost analysis, and formatted result output

…nsaction-simulation

scguaquetam

Please follow accordingly to current standard.

scguaquetam · 2025-12-08T10:32:13Z

src/commands/simulate.ts

+  error?: string;
+}
+
+function logInfo(message: string) {


This is wrong implemented, in order for this feature of CLI to be used in the MCP Server, we need normalize the usage of console chalk and spinner, in a external/nonexternal basis, for that please refer to other existing commands and check how they use this, for example THIS where we use logMessage and startSpinner, succeedSpinner, etc.

Thanks for the feedback. I've refactored simulate.ts to follow the standard pattern used in other commands

scguaquetam · 2025-12-08T10:32:41Z

src/commands/simulate.ts

+  const balanceAfterTransfer = currentTokenBalance - transferAmount;
+  const networkName = isTestnet ? "Rootstock Testnet" : "Rootstock Mainnet";
+
+  console.log("\n" + chalk.cyan("📊 SIMULATION RESULTS") + "\n");


console.log management.

scguaquetam · 2025-12-08T10:32:51Z

src/commands/simulate.ts

+    ]
+  });
+  console.log(simulationTable);
+


…rnal, switching to logMessage/logInfo/logError, simplifying function signatures, removing unused helpers, standardizing CLI vs external context handling, and cleaning up duplicate code

scguaquetam · 2025-12-12T10:15:47Z

bin/index.ts

+  });
+
+program.parse(process.argv);
+program.parse(process.argv);


you have this repeated here

scguaquetam · 2025-12-12T10:16:54Z

src/commands/simulate.ts

+  error?: string;
+}
+
+function logMessage(


In other PR you have implemented an improvement here with this management, is it okay if you do it here also?

Ad-Capital · 2025-12-14T14:29:12Z

Heyy.. I’ve made the necessary changes. Is there a chance this could be approved and included in the December 15th disbursement batch?

…

On Fri, Dec 12, 2025, 11:17 AM Sebas ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/commands/simulate.ts <#288 (comment)>: > + balances: { + currentBalance: string; + balanceAfterTransfer: string; + balanceAfterGas: string; + tokenSymbol: string; + }; + validation: { + sufficientBalance: boolean; + sufficientGas: boolean; + validTransaction: boolean; + }; + }; + error?: string; +} + +function logMessage( In other PR you have implemented an improvement here with this management, is it okay if you do it here also? — Reply to this email directly, view it on GitHub <#288 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/A7QZ75ITV4GUBYSPH747CTT4BKI2XAVCNFSM6AAAAACLTBPJFWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTKNZRGIYTMNZQGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

scguaquetam

Please take in account these comments for better implementation.

scguaquetam · 2026-01-07T07:36:55Z

src/commands/simulate.ts

+  const { balance: tokenBalance, decimals, name: tokenName, symbol: tokenSymbol } =
+    await getTokenInfo(publicClient, tokenAddress, walletAddress);
+
+  const currentTokenBalance = Number(tokenBalance) / (10 ** decimals);


Should we here use BigInt instead of Number? in case of managing too big values?
can we keep all in bigint?

scguaquetam · 2026-01-07T07:38:07Z

src/commands/simulate.ts

+async function simulateERC20Transfer(
+  params: TransactionSimulationOptions,
+  publicClient: any,
+  walletClient: any,


here you can use the PublicClient and WalletClient types from Viem instead of using any.

scguaquetam · 2026-01-07T07:38:44Z

src/utils/simulationUtils.ts

@@ -0,0 +1,162 @@
+import { PublicClient, Account, Address, parseEther, formatEther } from "viem";


parseEther ist not used here

scguaquetam · 2026-01-07T07:40:40Z

src/utils/simulationUtils.ts

+  amount: bigint,
+  gasPrice?: bigint
+): Promise<GasEstimationResult> {
+  let gasEstimate = BigInt(100000);


in this case, if the estimation fails, it is hardcoded, we should somehow , tell the user in this case this is a fallback or fixed value due to an error on estimation.

scguaquetam · 2026-01-07T07:41:46Z

src/utils/logger.ts

+  logMessage(isExternal, message, chalk.yellow);
+}
+
+export function capitalize(str: string): string {


I think this function is not being used on the project

had an idea for dynamic string formatting in the logger utilities and thought capitalize would be useful, but the idea didn't hold up after implementation, turns out hardcoded messages work better for this use case

scguaquetam · 2026-01-07T07:43:20Z

src/commands/simulate.ts

+  logMessage(params.isExternal || false, summaryMessage, isSuccessful ? chalk.green : chalk.red);
+
+  return {
+    success: true,


here, even if the transaction simulation fails, you are returning a success true, and other fields.

- Replace any types with PublicClient/WalletClient from Viem - Use BigInt for token balance calculations - Add fallback gas warning for users - Fix simulation result to return actual status instead of always true - Remove unused capitalize function and parseEther import - Add proper error logging and type guards

Add comprehensive documentation for the new simulate command that allows users to test RBTC and ERC20 token transfers before execution. Documentation includes usage examples, output samples, available options, and explanations of simulation results for both mainnet and testnet networks.

ezequiel-rodriguez

LGTM

ezequiel-rodriguez · 2026-01-20T22:09:27Z

hey @Ad-Capital,
Thanks for your contribution! It looks really helpful 💪
Someone from the hacktivator program will contact you in order to get your reward 😄
Keep contributing 😉

Ad-Capital added 3 commits November 9, 2025 21:01

feat(cli): add simulate command for testing RBTC and ERC20 transfers …

33aa2b0

…with gas estimation, balance validation, cost analysis, and formatted result output

clean up comments

47bec04

Merge branch 'main' of https://github.com/Ad-Capital/rsk-cli into tra…

1de95a9

…nsaction-simulation

scguaquetam reviewed Dec 8, 2025

View reviewed changes

refactor(simulate): normalize console output for MCP by adding isExte…

5ca418b

…rnal, switching to logMessage/logInfo/logError, simplifying function signatures, removing unused helpers, standardizing CLI vs external context handling, and cleaning up duplicate code

scguaquetam reviewed Dec 12, 2025

View reviewed changes

fix(simulate): remove duplicate program.parse and centralize logger

5cb5bdb

scguaquetam reviewed Jan 7, 2026

View reviewed changes

Ad-Capital added 2 commits January 7, 2026 21:37

ezequiel-rodriguez approved these changes Jan 20, 2026

View reviewed changes

ezequiel-rodriguez merged commit 0c52dc9 into rsksmart:main Jan 20, 2026
3 checks passed

		@@ -0,0 +1,162 @@
		import { PublicClient, Account, Address, parseEther, formatEther } from "viem";

Conversation

Ad-Capital commented Nov 9, 2025

Uh oh!

scguaquetam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Ad-Capital commented Dec 14, 2025 via email

Uh oh!

scguaquetam left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ezequiel-rodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ezequiel-rodriguez commented Jan 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants