Feat/rns manager: Support for Rootstock Name Service: register domains, update records, and transfer ownership using Rootstock rns-sdk#294
Merged
ezequiel-rodriguez merged 16 commits intorsksmart:mainfrom Feb 19, 2026
Conversation
…only with ethers v5
Collaborator
|
@youngancient Thanks for your contribution! 💪 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, I did the following:
Added Commands
rns:register: Register new domains (with 2-step commitment).rns:transfer: Transfer domain ownership (NFT transfer).rns:update: Update domain resolution address.Challenge
The rns:transfer and rns:update would not work on mainnet because the default mainnet address for the
partnerRegistrarAddressis missing in the library (check line 55 of the SDK)[https://github.com/rsksmart/rns-sdk/blob/develop/src/PartnerRegistrar.ts]. Everything works well on testnet. Once the address is updated in the SDK, it will work perfectly on the mainnet.