Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the "reed" bridge ABI release to the codebase, updating both mainnet and testnet configurations to recognize the new ABI at their respective activation block heights. The changes also update the dependency to use the latest precompiled ABIs.
- Added "reed" bridge ABI support for mainnet (block 8,052,200) and testnet (block 6,835,700)
- Updated
@rsksmart/rsk-precompiled-abisdependency to version8.0.0-REED - Extended test coverage to include the new "reed" ABI validation
Reviewed Changes
Copilot reviewed 4 out of 7 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/lib/nativeContracts/bridgeAbi.js | Added reed ABI import and configuration entries for mainnet and testnet |
| test/bridgeAbi.spec.js | Added reed ABI import and test cases for both networks |
| src/lib/nativeContracts/bridge-reed.json | New ABI definition file for the reed bridge release |
| package.json | Updated dependency version to 8.0.0-REED |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the bridge ABI support to include the new "reed" release for both mainnet and testnet. The changes ensure the codebase recognizes and properly handles the "reed" ABI at its respective activation block heights, and updates dependencies to use the latest ABI definitions.
Bridge ABI updates:
RSK_RELEASESfor mainnet (block 8,052,200) and testnet (block 6,835,700) withinsrc/lib/nativeContracts/bridgeAbi.js. [1] [2]bridge-reed.jsonABI file in both implementation (src/lib/nativeContracts/bridgeAbi.js) and test files (test/bridgeAbi.spec.js). [1] [2]Dependency update:
@rsksmart/rsk-precompiled-abisdependency inpackage.jsonto version8.0.0-REEDto use the latest precompiled ABIs.Test coverage:
test/bridgeAbi.spec.jsto include the "reed" ABI for both mainnet and testnet, ensuring correct ABI selection by block height.Next version notes:
We are considering the posibility of moving certain rootstock specific network settings to a dedicated repository (eg: bridge ABI selector logic by blockheight and network)