Mtmu integration#3608
Draft
julianlen wants to merge 61 commits into
Draft
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
julianlen
changed the base branch from
feat/calculate-tx-size-more-accurate
to
master
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ReleaseTransactionBuilder.BuildResult migrationTransactionResult = createMigrationTransaction(retiringFederationWallet, activeFederationAddress); | ||
| ReleaseTransactionBuilder.BuildResult migrationTransactionResult = activations.isActive(RSKIP455) ? | ||
| createMigrationTransaction(retiringFederationWallet, activeFederationAddress) : | ||
| createMigrationTransactionLegacy(retiringFederationWallet, activeFederationAddress); |
| if (!activations.isActive(ConsensusRule.RSKIP271)) { | ||
| return BridgeUtilsLegacy.calculatePegoutTxSize(activations, federation, inputsCount, outputsCount); | ||
| if (!activations.isActive(ConsensusRule.RSKIP378)) { | ||
| return BridgeUtilsLegacy.simulatePegoutTxSize(activations, federation, inputsCount, outputsCount); |
| Federation federation = FederationFactory.buildStandardMultiSigFederation(federationArgs); | ||
|
|
||
| int pegoutTxSize = BridgeUtilsLegacy.calculatePegoutTxSize(activations, federation, 2, 2); | ||
| int pegoutTxSize = BridgeUtilsLegacy.simulatePegoutTxSize(activations, federation, 2, 2); |
| Federation federation = FederationFactory.buildStandardMultiSigFederation(federationArgs); | ||
|
|
||
| Assertions.assertThrows(DeprecatedMethodCallException.class, () -> BridgeUtilsLegacy.calculatePegoutTxSize(activations, federation, 2, 2)); | ||
| Assertions.assertThrows(DeprecatedMethodCallException.class, () -> BridgeUtilsLegacy.simulatePegoutTxSize(activations, federation, 2, 2)); |
| Federation federation = FederationFactory.buildStandardMultiSigFederation(federationArgs); | ||
|
|
||
| Assertions.assertThrows(IllegalArgumentException.class, () -> BridgeUtilsLegacy.calculatePegoutTxSize(activations, federation, 0, 0)); | ||
| Assertions.assertThrows(IllegalArgumentException.class, () -> BridgeUtilsLegacy.simulatePegoutTxSize(activations, federation, 0, 0)); |
| } | ||
|
|
||
| // Add outputs | ||
| Address randomAddress = PegTestUtils.createRandomP2PKHBtcAddress(networkParameters); |
julianlen
changed the base branch from
master
to
feat/calculate-tx-size-more-accurate
julia-zack
force-pushed
the
feat/calculate-tx-size-more-accurate
branch
from
ce13402 to
989935a
Compare
…FedsWereBuiltAsExpected for pre and post rskip455
…vated, now it is 150 instead of 50
…xecuted under VETIVER activation
…orVETIVER for the first time it is created the bridgeStorageProvider for vetiver
…anged buildMigrationTransaction to receive a list of values to migrate
…ited it's behavior so the tests pass
…onstants instead of Bridge support, besides moved the migration outputs calculation to BridgeUtils, turned public and tested it. Also the calculation for the mtmu threshold was moved to BridgeUtils
…it name getMigrationTransactionOutputsValues
…rationTransactionOutputsValues and tested. Previous tests names were improved
…g the expected output list
…n exception, now it returns the value and migrateFunds logs and returns if the result is other than SUCCESS
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ionValueForMultipleOutputs it returns expectedMigrationValue as output
… rskip455 such that from rskip455 activation on the method hasMinimumFundsToMigrate is not evaluated anymore
julianlen
force-pushed
the
mtmu-integration
branch
from
b52c887 to
a79e94b
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: