Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support custom postcss options #9

Merged
merged 1 commit into from
Nov 12, 2024
Merged

feat: support custom postcss options #9

merged 1 commit into from
Nov 12, 2024

Conversation

colinaaa
Copy link
Collaborator

For Rspack plugin:

We add a new option postcssOptions which will be passed to postcss() and postcss().process().
.

For Rsbuild plugin:

We automatically read postcss options from Rsbuild config. It will be auto-loaded and merged from postcss.config.js and tools.postcss.

We also removes tailwindcss from postcssOptions.plugins to avoid @tailwind being transformed by postcss-loader.

close: #8

@colinaaa colinaaa requested a review from chenjiahan November 12, 2024 02:57
chenjiahan
chenjiahan approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@chenjiahan chenjiahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@colinaaa colinaaa merged commit 256dc2d into main Nov 12, 2024
2 checks passed
@colinaaa colinaaa deleted the postcss-config branch November 12, 2024 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenjiahan chenjiahan chenjiahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Custom PostCSS options
2 participants
@colinaaa @chenjiahan