Open
Conversation
This matcher is analog to the query assertions available since rails 7.0.
4eb5a1e to
80372b7
Compare
Author
|
There are a bunch of checks failing, but they don't seem related to this PR. For example: |
Author
|
Maybe I could do Also, I'm missing docs. The matcher should at least be added to the readme, and I need to figure out how those work in rspec. |
pirj
reviewed
Dec 3, 2024
| # expect { Post.first }.to execute_no_queries | ||
| # expect { Post.first }.to execute_no_queries.matching(/SELECT/) | ||
| # expect { Post.columns }.to execute_no_queries.including_schema | ||
| def execute_no_queries |
Member
There was a problem hiding this comment.
I would be leaning towards expect { }.not_to execute_queries, but an obvious use for this is compound expectations (and/or).
Member
Check the /features directory for examples.
That’s how we do it for most other matchers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matcher is analog to the query assertions available since rails 7.0.
#2817