feat: add Rsdoctor v2 migration skill - #115
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b0e345ed7b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| - Choose one Rsdoctor 2.x target version. Keep `@rsdoctor/core` and `@rsdoctor/cli` on the same version; version `@rsdoctor/agent-cli` independently. | ||
|
|
||
| 4. **Migrate packages and imports** | ||
| - Replace `@rsdoctor/rspack-plugin` with `@rsdoctor/core` and import `RsdoctorRspackPlugin` from `@rsdoctor/core`. |
There was a problem hiding this comment.
Update the analysis skill to recognize @rsdoctor/core
After this replacement, a migrated project that later invokes rsdoctor-analysis without an existing rsdoctor-data.json is treated as having no plugin: its Generation Gate only detects @rsdoctor/rspack-plugin or @rsdoctor/webpack-plugin (skills/rsdoctor-analysis/SKILL.md lines 44-52), and the referenced setup guide installs and imports @rsdoctor/rspack-plugin (references/install-rsdoctor-rspack.md lines 17-20 and 55-56). That adds the legacy plugin back alongside 2.x, directly undoing this migration and violating the new no-mixed-versions guardrail, so the analysis gate and installation references need a v2 @rsdoctor/core path as part of this change.
Useful? React with 👍 / 👎.
Summary
This PR adds a dedicated migration skill for projects moving from Rsdoctor 1.x to 2.0. It covers compatibility gates, package and ESM changes, configuration replacements, MCP-to-Agent CLI migration, and behavior-preserving validation.
TODO
Related Links
https://rsdoctor.rs/guide/start/migration-v2