Skip to content

feat: add Rsdoctor v2 migration skill - #115

Draft
yifancong wants to merge 2 commits into
mainfrom
feat-rsdoctor-migrate-v2
Draft

feat: add Rsdoctor v2 migration skill#115
yifancong wants to merge 2 commits into
mainfrom
feat-rsdoctor-migrate-v2

Conversation

@yifancong

@yifancong yifancong commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Summary

This PR adds a dedicated migration skill for projects moving from Rsdoctor 1.x to 2.0. It covers compatibility gates, package and ESM changes, configuration replacements, MCP-to-Agent CLI migration, and behavior-preserving validation.

TODO

  • After mergering, modify the description of the corresponding rsdoctor packages of rsdoctor-analysis

Related Links

https://rsdoctor.rs/guide/start/migration-v2

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b0e345ed7b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

- Choose one Rsdoctor 2.x target version. Keep `@rsdoctor/core` and `@rsdoctor/cli` on the same version; version `@rsdoctor/agent-cli` independently.

4. **Migrate packages and imports**
- Replace `@rsdoctor/rspack-plugin` with `@rsdoctor/core` and import `RsdoctorRspackPlugin` from `@rsdoctor/core`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Update the analysis skill to recognize @rsdoctor/core

After this replacement, a migrated project that later invokes rsdoctor-analysis without an existing rsdoctor-data.json is treated as having no plugin: its Generation Gate only detects @rsdoctor/rspack-plugin or @rsdoctor/webpack-plugin (skills/rsdoctor-analysis/SKILL.md lines 44-52), and the referenced setup guide installs and imports @rsdoctor/rspack-plugin (references/install-rsdoctor-rspack.md lines 17-20 and 55-56). That adds the legacy plugin back alongside 2.x, directly undoing this migration and violating the new no-mixed-versions guardrail, so the analysis gate and installation references need a v2 @rsdoctor/core path as part of this change.

Useful? React with 👍 / 👎.

@yifancong
yifancong marked this pull request as draft August 26, 2026 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant