Skip to content

feat: add some tool args for rsdoctor skills - #7

Merged
Timeless0911 merged 3 commits into
mainfrom
feat/add-rsdoctor-args
Feb 5, 2026
Merged

feat: add some tool args for rsdoctor skills#7
Timeless0911 merged 3 commits into
mainfrom
feat/add-rsdoctor-args

Conversation

@yifancong

@yifancong yifancong commented Feb 5, 2026

Copy link
Copy Markdown
Contributor

feat: add some tool args for rsdoctor skills

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @yifancong, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the rsdoctor-analysis tool by introducing new command-line functionalities and improving existing ones. The primary focus is on providing more control and better user experience for bundle optimization and package analysis, allowing users to perform detailed inspections with added flexibility like pagination.

Highlights

  • New Bundle Optimization Command: Introduced a new bundle optimize command with options for step-by-step execution and pagination for side effects analysis. This command allows for more granular control over bundle optimization processes.
  • Pagination for Package Listing: The package list command now supports pagination through --page-number and --page-size options, making it easier to manage and view large lists of packages.
  • TypeScript Configuration Update: Updated the tsconfig.json to target ES2022 and include a broader set of standard library definitions, enhancing compatibility and leveraging newer language features.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • packages/rsdoctor-analysis/src/commands/build.ts
    • Added a new bundle command group.
    • Implemented a bundle optimize subcommand with options for step, side-effects-page-number, and side-effects-page-size.
  • packages/rsdoctor-analysis/src/commands/packages.ts
    • Modified the listPackages function to accept pageNumberInput and pageSizeInput for pagination.
    • Updated the package list command to include --page-number and --page-size options, passing them to the listPackages function.
  • packages/rsdoctor-analysis/tsconfig.json
    • Updated compilerOptions to include lib for DOM, ES2015, ES2017, ES2020, ESNext and set target to ES2022.
  • skills/rsdoctor-analysis/scripts/rsdoctor.js
    • Reflected the new bundle optimize command and its options.
    • Reflected the pagination logic and options for the package list command.
Activity
  • No human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new bundle command as an alias for bundle optimization tasks and adds pagination support to the packages list command. The changes are logical and enhance the CLI's functionality. My main feedback is regarding a significant code duplication in the command registration, for which I've left a specific comment with a suggestion to refactor for better maintainability. The other changes look good.

Comment thread packages/rsdoctor-analysis/src/commands/build.ts Outdated
Comment thread packages/rsdoctor-analysis/tsconfig.json Outdated
@Timeless0911
Timeless0911 merged commit 2bab8eb into main Feb 5, 2026
4 checks passed
@Timeless0911
Timeless0911 deleted the feat/add-rsdoctor-args branch February 5, 2026 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants