Skip to content

fix: fallback to constructor.name when constructorName is not available#42

Merged
chenjiahan merged 1 commit intomainfrom
fix/runtime-module-constructor-name
Jan 19, 2026
Merged

fix: fallback to constructor.name when constructorName is not available#42
chenjiahan merged 1 commit intomainfrom
fix/runtime-module-constructor-name

Conversation

@LingyuCoder
Copy link
Copy Markdown
Contributor

Summary

This PR fixes an issue where runtimeModule.constructorName may not be available in certain Rspack versions. The change adds a fallback to use runtimeModule.constructor?.name when constructorName is not present, ensuring compatibility across different Rspack versions.

The fix ensures that the plugin can correctly identify the HotModuleReplacementRuntimeModule even when the constructorName property is not directly available on the runtime module instance.

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @LingyuCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a compatibility issue where the runtimeModule.constructorName property might be absent in specific Rspack versions. By introducing a fallback to runtimeModule.constructor?.name, the change guarantees consistent identification of runtime modules, thereby enhancing the plugin's robustness across different Rspack environments.

Highlights

  • Compatibility Fix: Implemented a fallback mechanism to use runtimeModule.constructor?.name when runtimeModule.constructorName is not available, addressing an issue with certain Rspack versions.
  • Module Identification: Ensures the plugin can correctly identify the HotModuleReplacementRuntimeModule regardless of the Rspack version's property availability.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly addresses an issue where runtimeModule.constructorName might not be available in some versions of Rspack by providing a fallback to runtimeModule.constructor?.name. The fix is straightforward and effective. I have one suggestion to further improve the code's robustness and clarity.

Comment thread src/index.ts
@chenjiahan chenjiahan merged commit c3c2023 into main Jan 19, 2026
4 checks passed
@chenjiahan chenjiahan deleted the fix/runtime-module-constructor-name branch January 19, 2026 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants