fix: fallback to constructor.name when constructorName is not available#42
Conversation
Summary of ChangesHello @LingyuCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves a compatibility issue where the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses an issue where runtimeModule.constructorName might not be available in some versions of Rspack by providing a fallback to runtimeModule.constructor?.name. The fix is straightforward and effective. I have one suggestion to further improve the code's robustness and clarity.
Summary
This PR fixes an issue where
runtimeModule.constructorNamemay not be available in certain Rspack versions. The change adds a fallback to useruntimeModule.constructor?.namewhenconstructorNameis not present, ensuring compatibility across different Rspack versions.The fix ensures that the plugin can correctly identify the
HotModuleReplacementRuntimeModuleeven when theconstructorNameproperty is not directly available on the runtime module instance.Checklist