feat(builder-rsbuild): support Storybook change detection#458
Draft
feat(builder-rsbuild): support Storybook change detection#458
Conversation
Amp-Thread-ID: https://ampcode.com/threads/T-019d4316-cf14-773f-87e0-1816f4d1ce11 Co-authored-by: Amp <amp@ampcode.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 71e01117a2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Amp-Thread-ID: https://ampcode.com/threads/T-019d4409-0b8b-756e-862d-f4a3d6c0e91b Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-019d4409-0b8b-756e-862d-f4a3d6c0e91b Co-authored-by: Amp <amp@ampcode.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This adds Storybook
changeDetectionsupport tostorybook-builder-rsbuildwithout requiring any new Rspack API.What changed
onModuleGraphChange(cb)support to the builderRspack Compilation.moduleGraphinto Storybook's builder-agnosticModuleGraphonDevCompileDonefor initial compile and rebuildslazyCompilationwhenfeatures.changeDetectionis enabled by composinglazyCompilation.testValidation
pnpm exec rstest 'packages/builder-rsbuild/tests/build-module-graph.test.ts' 'packages/builder-rsbuild/tests/index.test.ts' 'packages/builder-rsbuild/tests/preview/iframe-rsbuild.config.test.ts'storybook@0.0.0-pr-34370-sha-b4eae34cmodified/affectedstatuses in the Storybook UINotes
pnpm.overridesand thesandboxes/react-18features.changeDetectionflag are intentionally included on this preview branch to keep canary validation reproducible while debugging with Storybook maintainersmain