Skip to content

Conversation

kylebutts
Copy link

@kylebutts kylebutts commented Aug 19, 2021

Just a small thing. Here, you specify which font variants and weights to load. This causes error with pagedown::chrome_print because not every google font has every option. Fortunately, you don't need to specify any and it will load them all. So I think it's better to just delete that part of the line

gt/R/helpers.R

Line 2237 in df86e0c

":ital,wght@0,100;0,200;0,300;0,400;0,500;0,600;0,700;0,800;0,900;1,100;1,200;1,300;1,400;1,500;1,600;1,700;1,800;1,900&display=swap');"

@CLAassistant
Copy link

CLAassistant commented Aug 19, 2021

CLA assistant check
All committers have signed the CLA.

@kylebutts
Copy link
Author

I realize I never signed the CLA way back when. The same issue is still here with the same fix, so this should be good to merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants