Skip to content

Conversation

@alorbach
Copy link
Member

@alorbach alorbach commented Oct 6, 2025

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello @alorbach, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on integrating a new rsyslog module, mmleefparse.so, into the Debian packaging for rsyslog. By updating the rsyslog.install file, the change ensures that this new module is correctly deployed to the system's library path, making it available for rsyslog configurations.

Highlights

  • New Module Inclusion: The mmleefparse.so module has been added to the rsyslog installation manifest, ensuring it is packaged and installed with rsyslog.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@alorbach alorbach merged commit 8e854c3 into rsyslog:master Oct 6, 2025
2 of 4 checks passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the mmleefparse.so module to the list of files to be installed for the rsyslog package. However, the build for this module is not enabled in the Debian packaging rules, which will likely cause the package build to fail. My review includes a critical comment detailing this issue and how to resolve it.

usr/lib/${DEB_HOST_MULTIARCH}/rsyslog/mmpstrucdata.so
usr/lib/${DEB_HOST_MULTIARCH}/rsyslog/mmsequence.so
usr/lib/${DEB_HOST_MULTIARCH}/rsyslog/mmfields.so
usr/lib/${DEB_HOST_MULTIARCH}/rsyslog/mmleefparse.so

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change adds the mmleefparse.so module to the list of files to be installed. However, the module is not enabled in the build configuration in debian/rules. The package build will likely fail because dh_install will not find the mmleefparse.so file as it was never built.

To fix this, you need to enable the module in debian/rules by adding --enable-mmleefparse to the dh_auto_configure arguments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant