Skip to content

Refactor SMTP handling to avoid OAuth usage#23

Draft
wreckage0907 wants to merge 3 commits into
version-16-hotfixfrom
main
Draft

Refactor SMTP handling to avoid OAuth usage#23
wreckage0907 wants to merge 3 commits into
version-16-hotfixfrom
main

Conversation

@wreckage0907

Copy link
Copy Markdown

Please provide enough information so that others can review your pull request:

This pull request updates the logic for determining when to use OAuth authentication in the sendmail_config method of email_account.py. Instead of relying on the auth_method field, it now checks if both custom_outgoing_server_username and custom_outgoing_server_password are not set.

Authentication logic update:

  • Changed the calculation of use_oauth to be true when both custom_outgoing_server_username and custom_outgoing_server_password are not set, instead of checking if auth_method is "OAuth". (frappe_email_send_override/overrides/email_account.py)

Explain the details for making this change. What existing problem does the pull request solve?

QA List

Screenshots/GIFs

@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

@wreckage0907 wreckage0907 requested a review from niraj2477 May 25, 2026 07:50
@wreckage0907 wreckage0907 marked this pull request as draft May 25, 2026 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants