Refactor SMTP handling to avoid OAuth usage#23
Draft
wreckage0907 wants to merge 3 commits into
Draft
Conversation
refactor: Do not use oauth in case of smtp
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the logic for determining when to use OAuth authentication in the
sendmail_configmethod ofemail_account.py. Instead of relying on theauth_methodfield, it now checks if bothcustom_outgoing_server_usernameandcustom_outgoing_server_passwordare not set.Authentication logic update:
use_oauthto be true when bothcustom_outgoing_server_usernameandcustom_outgoing_server_passwordare not set, instead of checking ifauth_methodis"OAuth". (frappe_email_send_override/overrides/email_account.py)