Skip to content

Fix: security vulnerability - #314

Merged
mohdsayed merged 2 commits into
mainfrom
fix/security-vuls
Jul 31, 2026
Merged

Fix: security vulnerability#314
mohdsayed merged 2 commits into
mainfrom
fix/security-vuls

Conversation

@b1ink0

@b1ink0 b1ink0 commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator

Description

This PR fixes security vulnerabilities by updating them to patched versions and overriding vulnerable transitive dependencies.


Checklist

  • If this PR adds a new component, it has a linked issue that was discussed and approved before I started work.
  • I have thoroughly tested this code to the best of my abilities.
  • I have reviewed the code myself before requesting a review.
  • This code is covered by unit tests to verify that it works as intended.
  • The QA of this PR is done by a member of the QA team (to be checked by QA).

Fixes:

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Updates direct and transitive dependencies to patched versions to address multiple Dependabot security advisories.

Changes:

  • Bumped dompurify and echarts in packages/frappe-ui-react.
  • Updated Vitest-related tooling and babel-jest.
  • Adjusted dependency overrides to force patched versions of vulnerable transitive packages.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

File Description
packages/frappe-ui-react/package.json Updates direct dependencies (dompurify, echarts) to patched versions.
package.json Updates test tooling versions and extends/adjusts overrides for vulnerable transitive dependencies.
Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread package.json
Comment thread package.json
Comment thread package.json
@b1ink0
b1ink0 marked this pull request as draft July 27, 2026 11:16
@b1ink0
b1ink0 marked this pull request as ready for review July 27, 2026 14:19
Copilot AI review requested due to automatic review settings July 27, 2026 14:19

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 3 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • pnpm-lock.yaml: Generated file

Comment thread package.json
Comment thread package.json
Comment thread package.json
@mohdsayed
mohdsayed merged commit 01a13ae into main Jul 31, 2026
3 of 4 checks passed
@mohdsayed
mohdsayed deleted the fix/security-vuls branch July 31, 2026 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants