fix: video player controls buttons shift position in fullscreen on mobile.#1725
fix: video player controls buttons shift position in fullscreen on mobile.#1725Asteriskkkk wants to merge 1 commit intortCamp:developfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes a mobile fullscreen UI regression where skip/pause controls shift position when opening the engagement comment modal, by forcing a layout recalculation after the player DOM is moved into the modal.
Changes:
- Dispatches a resize event after moving the video wrapper into the comment modal to re-run control positioning logic on mobile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Asteriskkkk
force-pushed
the
fix/mobile-fullscreen-player-controls-shift
branch
from
177708a to
bf7ca1c
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a mobile fullscreen UI regression where the central controls (play/skip) shift position when the engagement comment modal is open by forcing a post-move resize so the control layout recalculates against the modal’s dimensions.
Changes:
- After moving the current player DOM into the comment modal, trigger a resize to reflow skip/control positioning.
- Prefer triggering a scoped Video.js
resizeon the player instance, with a fallback to dispatching a global windowresize.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Asteriskkkk
force-pushed
the
fix/mobile-fullscreen-player-controls-shift
branch
from
bf7ca1c to
d3e1235
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a mobile fullscreen UI issue in the GoDAM player where control buttons (pause/seek/skip) shift unexpectedly when engagement features are enabled and the comment box modal is open.
Changes:
- After moving the active video DOM into the comment modal container, triggers a resize to force Video.js/control layout recalculation.
- Prefers triggering a scoped
resizeevent on the Video.js player instance, with a fallback to dispatching a global windowresize.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Asteriskkkk
force-pushed
the
fix/mobile-fullscreen-player-controls-shift
branch
from
d3e1235 to
6c56792
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a mobile fullscreen layout issue where central player controls (pause/seek/skip) shift position when engagement/comment modal is open by forcing a post-move resize recalculation after the video DOM is moved into the modal container.
Changes:
- After appending the current video into the comment modal container, triggers a Video.js
resizeevent when possible. - Adds a fallback path that dispatches a global
windowresizeevent if a player instance can’t be resolved.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Asteriskkkk
force-pushed
the
fix/mobile-fullscreen-player-controls-shift
branch
from
6c56792 to
64db5da
Compare
There was a problem hiding this comment.
Pull request overview
Fixes a mobile fullscreen layout issue where skip/seek controls shift position after opening the engagement comment modal by forcing a player/layout resize once the video DOM is moved into the modal container.
Changes:
- After moving the current video into the comment modal container, attempt to trigger a Video.js
resizeevent. - Add a fallback to dispatch a global
windowresizeevent if the Video.js call errors.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| try { | ||
| const player = window.videojs.getPlayer( videoElement ); | ||
| if ( player && typeof player.trigger === 'function' ) { | ||
| player.trigger( 'resize' ); | ||
| } | ||
| } catch ( error ) { | ||
| // fall back to dispatching a global window resize event. | ||
| window.dispatchEvent( new Event( 'resize' ) ); | ||
| } | ||
|
|
| // fall back to dispatching a global window resize event. | ||
| window.dispatchEvent( new Event( 'resize' ) ); | ||
| } | ||
|
|
…n fullscreen on mobile. In mobile view, when a video has engagement options enabled and the comment box is open, the player controls (pause and seek/forward) change position unexpectedly when entering fullscreen.
Asteriskkkk
force-pushed
the
fix/mobile-fullscreen-player-controls-shift
branch
from
64db5da to
b2331da
Compare
Fixes: #1527.
In mobile view, when a video has engagement options enabled and the comment box is open, the player controls (pause and seek/forward) change position unexpectedly when entering fullscreen.