fix: Hide control bar when playback controls are disabled, only display play button#1732
Open
subodhr258 wants to merge 2 commits intodevelopfrom
Open
fix: Hide control bar when playback controls are disabled, only display play button#1732subodhr258 wants to merge 2 commits intodevelopfrom
subodhr258 wants to merge 2 commits intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts GoDAM player behavior when the block’s “Playback controls” toggle is disabled so that the control bar is hidden while the big play button remains usable (including as a replay affordance after playback ends).
Changes:
- Track the “Playback controls” toggle state in
ConfigurationManagerwhile still passingcontrols: trueto Video.js to preserve big play button behavior. - Add a
godam-no-controls-barclass inControlsManagerwhen playback controls are disabled. - Add CSS to hide the control bar under
godam-no-controls-barand re-show the big play button onvjs-ended.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| assets/src/js/godam-player/managers/controlsManager.js | Adds conditional classing to hide the control bar when playback controls are disabled. |
| assets/src/js/godam-player/managers/configurationManager.js | Persists the block toggle state while forcing controls:true for Video.js. |
| assets/src/css/godam-player.scss | Hides .vjs-control-bar when controls are disabled and re-displays the big play button on end. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
missing_composer_json_file | The "/vendor" directory using composer exists, but "composer.json" file is missing. |
📁 readme.txt (2 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" is different from the name declared in plugin header "GoDAM". |
0 |
trademarked_term | The plugin name includes a restricted term. Your chosen plugin name - "GoDAM - Organize WordPress Media Library & File Manager with Unlimited Folders for Images, Videos & more" - contains the restricted term "wordpress" which cannot be used at all in your plugin name. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (6 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/03/16/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?godam-video=demo-godam-video-post (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (6 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/03/16/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/?godam-video=demo-godam-video-post (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
Collaborator
|
@subodhr258 @hashibhere Screen.Recording.2026-03-17.at.11.23.17.AM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue - #1570
This pull request improves the behavior and configuration of playback controls in the Godam video player, especially when the "Playback controls" toggle is disabled in the block settings. The main focus is to ensure that the big play button remains visible and functional for replay, even when the control bar (seek bar, volume, etc.) is hidden.
Playback Controls Toggle Handling:
ConfigurationManagerto track whether the "Playback controls" block toggle is enabled, ensuring that when disabled, only the control bar is hidden but the big play button remains functional (assets/src/js/godam-player/managers/configurationManager.js).ControlsManagerto add agodam-no-controls-barclass to the player element when playback controls are disabled, which hides the control bar while preserving the big play button (assets/src/js/godam-player/managers/controlsManager.js).CSS Updates for Control Bar and Play Button:
.godam-no-controls-baris present, and to re-show the big play button as a replay prompt after playback ends, even when controls are hidden (assets/src/css/godam-player.scss).assets/src/css/godam-player.scss).