Set 'eager' loading for videos with priority performance#1820
Open
KMchaudhary wants to merge 1 commit intodevelopfrom
Open
Set 'eager' loading for videos with priority performance#1820KMchaudhary wants to merge 1 commit intodevelopfrom
KMchaudhary wants to merge 1 commit intodevelopfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates GoDAM’s video performance configuration so that when a video is in priority performance mode, the poster <img> is explicitly configured to load eagerly (in addition to having high fetch priority), aligning poster loading behavior with the intent of “priority” mode.
Changes:
- Add
loading => eagertoposter_attributeswhen performance mode ispriorityinrtgodam_get_video_performance_settings().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a small update to the video performance settings in the
rtgodam_get_video_performance_settingsfunction. The change ensures that when the mode is set to'priority', the video poster image will now load eagerly in addition to having a high fetch priority.'loading' => 'eager'attribute to theposter_attributesarray for priority mode inrtgodam_get_video_performance_settingsininc/helpers/custom-functions.php