Remove portable-atomic from rtic-monotonics
#1134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
korken89
force-pushed
the
fix-monotonics-atomics
branch
5 times, most recently
from
8adea3a to
c0eb645
Compare
korken89
force-pushed
the
fix-monotonics-atomics
branch
from
c0eb645 to
8c93467
Compare
|
It would be nice to keep portable-atomics around. Outside of this one deadlock issue, portable-atomics generally has ways to emulate atomics that are more efficient than a critical section around every operation, especially on multicore systems. |
Collaborator
Author
|
If they get our base case fixed, then we can keep it. I'm not that positive to keep it when especially if it can cause dead locks. Could you @FeldrinH champion the fixing of that create? |
|
I can try to if I can reproduce the deadlock on hardware I own. Unfortunately I do not own any armv7m devices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1117