ROUTING-1322 - Improving UDP socket adapter plugin example. Adding Data-diode reference in doc. #741

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

juanlu-rti merged 9 commits into rticommunity:master from iutrilladn:master

Nov 18, 2025

iutrilladn commented Jul 8, 2025

Summary

Routing service adapter for udp socket example improvements.

New example using dynamic data
Old example is now bidirectional

Details and comments

udp_socket_adapter now includes converting from DDS to UDP socket
New use case in README.md for data-diode environment.
New example using dynamic data
Split udp_socket example into two, dynamic and non dynamic example

about 99% of the code is the same in both examples.
I am open to reconfigure in a way that both can coexist in the same code using #ifdef statements, but I consider this way to be more clear.

Note:
Original example of udp_socket_adapter was not included in defaults for CMakeLists,txt. I have kept it the same way.

Checks

I have updated the documentation accordingly.
I have read the CONTRIBUTING document.

iutrilla-rti added 6 commits

July 7, 2025 11:57


          Added new test to read received data through a socket

decd68c


          Added writer

5a1ad4f


          Split example into two. Dynamic work in progress

38f0644


          Edited Readme files and minor adjustments

962e46b


          Minor md formatting issues and new explanations

231d224


          Removed stray file

68d3436

juanlu-rti self-requested a review

August 5, 2025 14:59

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/README.md Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/README.md Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/README.md Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/README.md Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketConnection.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketConnection.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketInputDiscoveryStreamReader.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketInputDiscoveryStreamReader.hpp Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.cxx Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamReader.hpp Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.cxx Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.hpp Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.hpp Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.hpp Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/SocketStreamWriter.hpp Outdated Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_dynamic/src/UdpSocket.cxx Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_typed/README.md Show resolved Hide resolved

juanlu-rti reviewed

View reviewed changes

examples/routing_service/udp_socket_adapter_typed/RsSocketAdapter.xml Outdated Show resolved Hide resolved

iutrilla-rti added 3 commits

August 12, 2025 11:06


          Review changes. Minor changes applied

a1e47f0


          Review changes. Stream writer and reader improvements

49489ea


          Review changes. Added descriptions to classes. MInor fixes

e25f691

Member

juanlu-rti commented Sep 16, 2025

Changes applying feedback look fine. Did you measure performance after the changes? Just out of curiosity. Anyhow, approving.

juanlu-rti approved these changes

View reviewed changes

Author

iutrilladn commented Sep 17, 2025 •

edited

Loading

Hi @juanlu-rti
Thanks for the review. I did not measure performance after the changes.
I don't think I have write permissions. Could you merge for me of give me write permission for this merge?

juanlu-rti merged commit 19d2357 into rticommunity:master

1 of 4 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet