fix(git): preserve patch output for log -p#2276
Open
puneetdixit200 wants to merge 1 commit into
Open
Conversation
|
puneetdixit200 seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2275.
git log -pasks git for patch output, but the current log path still runs the result through RTK's log summarizer. That treats the diff as commit-body text and drops the patch lines.This change detects explicit patch-style log flags and sends that command through unchanged, preserving the full diff when the caller asks for it.
Validation
cargo fmt --all --checkCARGO_TARGET_DIR=/private/tmp/rtkbuild-2275 cargo test test_log_patch_args_request_passthrough -j1CARGO_TARGET_DIR=/private/tmp/rtkbuild-2275 cargo test filter_log_output -j1CARGO_TARGET_DIR=/private/tmp/rtkbuild-2275 cargo run --quiet -- git log -p -1 -- src/cmds/git/git.rsCARGO_TARGET_DIR=/private/tmp/rtkbuild-2275 cargo test -j1CARGO_TARGET_DIR=/private/tmp/rtkbuild-2275 cargo clippy --all-targets -j1