Skip to content

fix(go): preserve test and vet diagnostics#2284

Open
jsiu93 wants to merge 1 commit into
rtk-ai:developfrom
jsiu93:fix/go-filter-exit-fallback
Open

fix(go): preserve test and vet diagnostics#2284
jsiu93 wants to merge 1 commit into
rtk-ai:developfrom
jsiu93:fix/go-filter-exit-fallback

Conversation

@jsiu93
Copy link
Copy Markdown
Contributor

@jsiu93 jsiu93 commented Jun 5, 2026

Closes #2281.

Summary

  • Route rtk go test and rtk go vet through exit-aware filtering so non-zero Go failures cannot be summarized as empty results.
  • Preserve real Go diagnostics such as undefined, cannot, and import cycle from raw output and go test -json output events.
  • Share Go diagnostic formatting across build/test/vet and strip ANSI before matching.

Test plan

  • cargo fmt --all -- --check
  • cargo clippy --all-targets
  • cargo test --all --quiet
  • Manual repro: rtk go test ./... and rtk go vet ./... in a temporary Go project with undefined: missingSymbol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rtk go / Go filters can hide real compiler errors and report misleading success

1 participant