fix(git): rewrite -C with quoted paths#2309
Open
fengjikui wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git -C "path with spaces" <subcommand>routes throughrtk git-Cpath in the rewritten commandContext
Issue #2303 reports missed
git -C <path>rewrites. Currentdevelopalready handles unquoted paths such asgit -C /tmp status, but the same rewrite still missed valid quoted paths with spaces because the matcher only accepted\S+values.Before this change, the Claude hook produced no rewrite for:
git -C "/tmp/foo bar" statusAfter this change it rewrites to:
rtk git -C "/tmp/foo bar" statusValidation
cargo fmt --checkcargo test discover::registry::testscargo testcargo clippy --all-targets -- -D warningsgit diff --checkgit -C "/tmp/foo bar" statusAI Assistance
This PR was prepared with OpenAI Codex assistance. I reviewed the diff and ran the validation above before submitting.