fix: propagate JSON parse error instead of silently overwriting Gemini settings - #3503
Open
mmustafasenoglu wants to merge 1 commit into
Open
fix: propagate JSON parse error instead of silently overwriting Gemini settings#3503mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
…i settings
The Gemini installer used .unwrap_or(serde_json::json!({})) which swallows
parse errors (BOM, trailing commas, half-written files) and overwrites the
user's entire settings.json with an empty object.
The Claude, Cursor, and Droid installers all use .with_context()? to propagate
the error. This applies the same pattern to the Gemini path.
Closes rtk-ai#3400
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3400
The Gemini installer used
.unwrap_or(serde_json::json!({}))which swallows JSON parse errors (BOM, trailing commas, half-written files) and silently overwrites the user's entire~/.gemini/settings.jsonwith an empty object.The Claude, Cursor, and Droid installers all use
.with_context()?to propagate the error. This applies the same pattern to the Gemini path so the install fails loudly with the path and the parse error instead of overwriting.