fix: check for RTK heading instead of bare substring in rules files - #3504
Open
mmustafasenoglu wants to merge 1 commit into
Open
fix: check for RTK heading instead of bare substring in rules files#3504mmustafasenoglu wants to merge 1 commit into
mmustafasenoglu wants to merge 1 commit into
Conversation
The Cline/Windsurf/Kilo/Antigravity installers checked if the rules file contained "RTK" or "rtk" to detect existing configuration. This falsely matched unrelated content (e.g. "RTK Query" in a Redux project). Changed to check for the actual heading the installer writes: "# RTK - Rust Token Killer" Closes rtk-ai#3406
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3406
The Cline/Windsurf/Kilo/Antigravity installers checked if the rules file contained
"RTK"or"rtk"to detect existing configuration. This falsely matched unrelated content — e.g. a Redux project's.clinerulesmentioning "RTK Query" would cause the installer to skip silently and report success.Changed all four checks to look for the actual heading the installer writes:
"# RTK - Rust Token Killer". This is specific enough to avoid false positives while still correctly detecting existing RTK installations.